Skip to content

Conversation

@boomanaiden154
Copy link
Contributor

As we have discussed in the past, we should be using the latest version. This has not been updated in a while.

As we have discussed in the past, we should be using the latest version. This
has not been updated in a while.
@llvmbot
Copy link
Member

llvmbot commented May 28, 2025

@llvm/pr-subscribers-github-workflow

Author: Aiden Grossman (boomanaiden154)

Changes

As we have discussed in the past, we should be using the latest version. This has not been updated in a while.


Full diff: https://github.com/llvm/llvm-project/pull/141819.diff

1 Files Affected:

  • (modified) .github/workflows/pr-code-format.yml (+1-1)
diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 063fe5679a399..05d69861e1841 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -55,7 +55,7 @@ jobs:
       - name: Install clang-format
         uses: aminya/setup-cpp@17c11551771948abc5752bbf3183482567c7caf0 # v1.1.1
         with:
-          clangformat: 19.1.6
+          clangformat: 20.1.5
 
       - name: Setup Python env
         uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0

@tru
Copy link
Collaborator

tru commented May 28, 2025

Maybe we could automate bumping this when we do a release?

@boomanaiden154
Copy link
Contributor Author

Maybe we could automate bumping this when we do a release?

Potentially. Something like the version bump script should work.

@boomanaiden154 boomanaiden154 merged commit 46f9016 into llvm:main May 28, 2025
11 checks passed
@boomanaiden154 boomanaiden154 deleted the bump-pr-code-format-20-1-5 branch May 28, 2025 19:16
@owenca
Copy link
Contributor

owenca commented May 30, 2025

I was about to update the version and was waiting for 20.1.6, which has at least one relevant bug fix. Also, I don't anticipate any more clang-format patches for 20.1.x, so we don't need to wait for the final 20.1.x release.

Maybe we could automate bumping this when we do a release?

We should probably do it for the .0 release (optional) and at the end of a release.

@boomanaiden154
Copy link
Contributor Author

We should probably do it for the .0 release (optional) and at the end of a release.

End of a release cycle sounds good to me. I was going to say we need to update the documentation, but it doesn't look like the coding standards mention clang-format anywhere....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants