[mlir][xegpu] Add XeGPU subgroup map propagation analysis for XeGPU SIMT distribution. #130240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akroviakov @Jianhui-Li @Garra1980 Can you please have a look? |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Garra1980
reviewed
Mar 7, 2025
can you maybe elaborate a bit how distribution phase will further use this analysis results? |
updated the description. |
Jianhui-Li
reviewed
Mar 7, 2025
Jianhui-Li
reviewed
Mar 7, 2025
Jianhui-Li
reviewed
Mar 7, 2025
Jianhui-Li
reviewed
Mar 7, 2025
Jianhui-Li
reviewed
Mar 8, 2025
Jianhui-Li
reviewed
Mar 8, 2025
akroviakov
reviewed
Mar 12, 2025
adam-smnk
reviewed
Mar 12, 2025
Jianhui-Li
approved these changes
Mar 13, 2025
adam-smnk
approved these changes
Mar 13, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/203/builds/4686 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/3499 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/3477 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/138/builds/11696 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/89/builds/18677 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/80/builds/11346 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/130/builds/11184 Here is the relevant piece of the build log for the reference |
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 14, 2025
…nalysis for XeGPU SIMT distribution." (#131364) Reverts llvm/llvm-project#130240
charithaintc
added a commit
that referenced
this pull request
Mar 14, 2025
… XeGPU SIMT distribution. (#131380) Originally introduced in #130240 and reverted in #131364 Reproduced the issue locally in Linux by doing a shared lib build. Fixes including adding the missing LINK_LIBS. **Original commit message:** This PR adds the SG map propagation step of the XeGPU SIMT distribution. SG map propagation is a sparse backward dataflow analysis that propagate the sg_map backward starting from the operands of certain operations (DPAS, store etc.). This is the first step of XeGPU subgroup distribution. This analysis result is used to attach layout information to each XeGPU SIMD subgroup op. The lowering patterns in XeGPUSubgroupDistribute will consume these layout info to distribute SIMD ops into SIMT ops that work on work-item level data fragments. Summary of Lowering XeGPU SIMD -> SIMT Subgroup map propagation (This PR) Attach sg_map to each op in move all ops inside gpu.warp_execute_on_lane0 region. Distribute each op using sg_map Additional legalization steps to align more with Xe HW.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the SG map propagation step of the XeGPU SIMT distribution. SG map propagation is a sparse backward dataflow analysis that propagate the sg_map backward starting from the operands of certain operations (DPAS, store etc.).
This is the first step of XeGPU subgroup distribution. This analysis result is used to attach layout information to each XeGPU SIMD subgroup op. The lowering patterns in XeGPUSubgroupDistribute will consume these layout info to distribute SIMD ops into SIMT ops that work on work-item level data fragments.
Summary of Lowering XeGPU SIMD -> SIMT
sg_mapto each op in move all ops insidegpu.warp_execute_on_lane0region.sg_map