Skip to content

Conversation

@thurstond
Copy link
Contributor

Forked from llvm/test/CodeGen/Generic/expand-experimental-reductions.ll

Handled suboptimally by visitInstruction:

  • llvm.vector.reduce.smax
  • llvm.vector.reduce.smin
  • llvm.vector.reduce.umax
  • llvm.vector.reduce.umin
  • llvm.vector.reduce.fmax
  • llvm.vector.reduce.fmin

Forked from llvm/test/CodeGen/Generic/expand-experimental-reductions.ll

Handled suboptimally by visitInstruction:
- llvm.vector.reduce.smax
- llvm.vector.reduce.smin
- llvm.vector.reduce.umax
- llvm.vector.reduce.umin
- llvm.vector.reduce.fmax
- llvm.vector.reduce.fmin
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

✅ With the latest revision this PR passed the undef deprecator.

@thurstond thurstond requested a review from fmayer March 4, 2025 21:39
@thurstond thurstond merged commit dec4cae into llvm:main Mar 5, 2025
11 checks passed
thurstond added a commit to thurstond/llvm-project that referenced this pull request Mar 5, 2025
Changes the handling of:
- llvm.aarch64.neon.smaxv
- llvm.aarch64.neon.sminv
- llvm.aarch64.neon.umaxv
- llvm.aarch64.neon.uminv
- llvm.vector.reduce.smax
- llvm.vector.reduce.smin
- llvm.vector.reduce.umax
- llvm.vector.reduce.umin
- llvm.vector.reduce.fmax
- llvm.vector.reduce.fmin
from the default strict handling (visitInstruction) to
handleVectorReduceIntrinsic.

Updates the tests from llvm#129741, llvm#129810, llvm#129768
thurstond added a commit that referenced this pull request Mar 9, 2025
…ns (#129819)

Changes the handling of:
- llvm.aarch64.neon.smaxv
- llvm.aarch64.neon.sminv
- llvm.aarch64.neon.umaxv
- llvm.aarch64.neon.uminv
- llvm.vector.reduce.smax
- llvm.vector.reduce.smin
- llvm.vector.reduce.umax
- llvm.vector.reduce.umin
- llvm.vector.reduce.fmax
- llvm.vector.reduce.fmin
from the default strict handling (visitInstruction) to
handleVectorReduceIntrinsic.

Also adds a parameter to handleVectorReduceIntrinsic to specify whether
the return type must match the elements of the vector.

Updates the tests from #129741,
#129810,
#129768
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request Mar 9, 2025
… instructions (#129819)

Changes the handling of:
- llvm.aarch64.neon.smaxv
- llvm.aarch64.neon.sminv
- llvm.aarch64.neon.umaxv
- llvm.aarch64.neon.uminv
- llvm.vector.reduce.smax
- llvm.vector.reduce.smin
- llvm.vector.reduce.umax
- llvm.vector.reduce.umin
- llvm.vector.reduce.fmax
- llvm.vector.reduce.fmin
from the default strict handling (visitInstruction) to
handleVectorReduceIntrinsic.

Also adds a parameter to handleVectorReduceIntrinsic to specify whether
the return type must match the elements of the vector.

Updates the tests from llvm/llvm-project#129741,
llvm/llvm-project#129810,
llvm/llvm-project#129768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants