Skip to content

IRBuilder: Add FMFSource parameter to CreateMaxNum/CreateMinNum #129173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

IRBuilder: Add FMFSource parameter to CreateMaxNum/CreateMinNum #129173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de75517
IRBuilder: Add FMFSource parameter to CreateMaxNum/CreateMinNum
wzssyqa Feb 28, 2025
2050994
para order
wzssyqa Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clang/lib/CodeGen/CGBuiltin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4378,7 +4378,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
: llvm::Intrinsic::umax,
Op0, Op1, nullptr, "elt.max");
} else
Result = Builder.CreateMaxNum(Op0, Op1, "elt.max");
Result = Builder.CreateMaxNum(Op0, Op1, /*FMFSource=*/nullptr, "elt.max");
return RValue::get(Result);
}
case Builtin::BI__builtin_elementwise_min: {
Expand All @@ -4394,7 +4394,7 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
: llvm::Intrinsic::umin,
Op0, Op1, nullptr, "elt.min");
} else
Result = Builder.CreateMinNum(Op0, Op1, "elt.min");
Result = Builder.CreateMinNum(Op0, Op1, /*FMFSource=*/nullptr, "elt.min");
return RValue::get(Result);
}

Expand Down
16 changes: 10 additions & 6 deletions llvm/include/llvm/IR/IRBuilder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,23 +1005,27 @@ class IRBuilderBase {
const Twine &Name = "");

/// Create call to the minnum intrinsic.
Value *CreateMinNum(Value *LHS, Value *RHS, const Twine &Name = "") {
Value *CreateMinNum(Value *LHS, Value *RHS, FMFSource FMFSource = {},
const Twine &Name = "") {
if (IsFPConstrained) {
return CreateConstrainedFPUnroundedBinOp(
Intrinsic::experimental_constrained_minnum, LHS, RHS, nullptr, Name);
Intrinsic::experimental_constrained_minnum, LHS, RHS, FMFSource,
Name);
}

return CreateBinaryIntrinsic(Intrinsic::minnum, LHS, RHS, nullptr, Name);
return CreateBinaryIntrinsic(Intrinsic::minnum, LHS, RHS, FMFSource, Name);
}

/// Create call to the maxnum intrinsic.
Value *CreateMaxNum(Value *LHS, Value *RHS, const Twine &Name = "") {
Value *CreateMaxNum(Value *LHS, Value *RHS, FMFSource FMFSource = {},
const Twine &Name = "") {
if (IsFPConstrained) {
return CreateConstrainedFPUnroundedBinOp(
Intrinsic::experimental_constrained_maxnum, LHS, RHS, nullptr, Name);
Intrinsic::experimental_constrained_maxnum, LHS, RHS, FMFSource,
Name);
}

return CreateBinaryIntrinsic(Intrinsic::maxnum, LHS, RHS, nullptr, Name);
return CreateBinaryIntrinsic(Intrinsic::maxnum, LHS, RHS, FMFSource, Name);
}

/// Create call to the minimum intrinsic.
Expand Down
Loading