[mlir] Add two clone methods about encoding to RankedTensorType. #127709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are clone methods for shape and element type, but not for encodings. The revision adds two clone method to RankedTensorType: - dropEncoding(): Return a clone of this type without the encoding. - cloneWithEncoding(Attribute encoding): Return a clone of this type with the given new encoding and the same shape and element type as this type. Signed-off-by: hanhanW <[email protected]>
Member
|
@llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir-ods Author: Han-Chung Wang (hanhanW) ChangesThere are clone methods for shape and element type, but not for encodings. The revision adds two clone method to RankedTensorType:
Full diff: https://github.com/llvm/llvm-project/pull/127709.diff 2 Files Affected:
diff --git a/mlir/include/mlir/IR/BuiltinTypes.td b/mlir/include/mlir/IR/BuiltinTypes.td
index e5a2ae81da0c9..af474b3e3ec47 100644
--- a/mlir/include/mlir/IR/BuiltinTypes.td
+++ b/mlir/include/mlir/IR/BuiltinTypes.td
@@ -1035,6 +1035,17 @@ def Builtin_RankedTensor : Builtin_Type<"RankedTensor", "tensor", [
RankedTensorType clone(::mlir::Type elementType) {
return ::llvm::cast<RankedTensorType>(cloneWith(getShape(), elementType));
}
+
+ /// Return a clone of this type without the encoding.
+ RankedTensorType dropEncoding() {
+ return RankedTensorType::get(getShape(), getElementType());
+ }
+
+ /// Return a clone of this type with the given new encoding and the same
+ /// shape and element type as this type.
+ RankedTensorType cloneWithEncoding(::mlir::Attribute encoding) {
+ return RankedTensorType::get(getShape(), getElementType(), encoding);
+ }
}];
let skipDefaultBuilders = 1;
let genVerifyDecl = 1;
diff --git a/mlir/unittests/IR/ShapedTypeTest.cpp b/mlir/unittests/IR/ShapedTypeTest.cpp
index c2900b5aaeeeb..bc4066ed210e8 100644
--- a/mlir/unittests/IR/ShapedTypeTest.cpp
+++ b/mlir/unittests/IR/ShapedTypeTest.cpp
@@ -282,6 +282,20 @@ TEST(ShapedTypeTest, RankedTensorTypeView) {
ASSERT_TRUE(mlir::isa<RankedTensorType>(viewCreated));
view = mlir::cast<TensorWithString>(viewCreated);
EXPECT_EQ(view.getName(), "bob");
+
+ // Verify encoding clone methods.
+ EXPECT_EQ(unitEncodingRankedTensorType,
+ cast<RankedTensorType>(noEncodingRankedTensorType)
+ .cloneWithEncoding(unitAttr));
+ EXPECT_EQ(stringEncodingRankedTensorType,
+ cast<RankedTensorType>(noEncodingRankedTensorType)
+ .cloneWithEncoding(stringAttr));
+ EXPECT_EQ(
+ noEncodingRankedTensorType,
+ cast<RankedTensorType>(unitEncodingRankedTensorType).dropEncoding());
+ EXPECT_EQ(
+ noEncodingRankedTensorType,
+ cast<RankedTensorType>(stringEncodingRankedTensorType).dropEncoding());
}
} // namespace
|
Member
|
@llvm/pr-subscribers-mlir Author: Han-Chung Wang (hanhanW) ChangesThere are clone methods for shape and element type, but not for encodings. The revision adds two clone method to RankedTensorType:
Full diff: https://github.com/llvm/llvm-project/pull/127709.diff 2 Files Affected:
diff --git a/mlir/include/mlir/IR/BuiltinTypes.td b/mlir/include/mlir/IR/BuiltinTypes.td
index e5a2ae81da0c9..af474b3e3ec47 100644
--- a/mlir/include/mlir/IR/BuiltinTypes.td
+++ b/mlir/include/mlir/IR/BuiltinTypes.td
@@ -1035,6 +1035,17 @@ def Builtin_RankedTensor : Builtin_Type<"RankedTensor", "tensor", [
RankedTensorType clone(::mlir::Type elementType) {
return ::llvm::cast<RankedTensorType>(cloneWith(getShape(), elementType));
}
+
+ /// Return a clone of this type without the encoding.
+ RankedTensorType dropEncoding() {
+ return RankedTensorType::get(getShape(), getElementType());
+ }
+
+ /// Return a clone of this type with the given new encoding and the same
+ /// shape and element type as this type.
+ RankedTensorType cloneWithEncoding(::mlir::Attribute encoding) {
+ return RankedTensorType::get(getShape(), getElementType(), encoding);
+ }
}];
let skipDefaultBuilders = 1;
let genVerifyDecl = 1;
diff --git a/mlir/unittests/IR/ShapedTypeTest.cpp b/mlir/unittests/IR/ShapedTypeTest.cpp
index c2900b5aaeeeb..bc4066ed210e8 100644
--- a/mlir/unittests/IR/ShapedTypeTest.cpp
+++ b/mlir/unittests/IR/ShapedTypeTest.cpp
@@ -282,6 +282,20 @@ TEST(ShapedTypeTest, RankedTensorTypeView) {
ASSERT_TRUE(mlir::isa<RankedTensorType>(viewCreated));
view = mlir::cast<TensorWithString>(viewCreated);
EXPECT_EQ(view.getName(), "bob");
+
+ // Verify encoding clone methods.
+ EXPECT_EQ(unitEncodingRankedTensorType,
+ cast<RankedTensorType>(noEncodingRankedTensorType)
+ .cloneWithEncoding(unitAttr));
+ EXPECT_EQ(stringEncodingRankedTensorType,
+ cast<RankedTensorType>(noEncodingRankedTensorType)
+ .cloneWithEncoding(stringAttr));
+ EXPECT_EQ(
+ noEncodingRankedTensorType,
+ cast<RankedTensorType>(unitEncodingRankedTensorType).dropEncoding());
+ EXPECT_EQ(
+ noEncodingRankedTensorType,
+ cast<RankedTensorType>(stringEncodingRankedTensorType).dropEncoding());
}
} // namespace
|
cheezeburglar
pushed a commit
to cheezeburglar/llvm-project
that referenced
this pull request
Feb 28, 2025
…m#127709) There are clone methods for shape and element type, but not for encodings. The revision adds two clone method to RankedTensorType: - dropEncoding(): Return a clone of this type without the encoding. - cloneWithEncoding(Attribute encoding): Return a clone of this type with the given new encoding and the same shape and element type as this type. Signed-off-by: hanhanW <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are clone methods for shape and element type, but not for encodings. The revision adds two clone method to RankedTensorType: