Skip to content

Add mlir-query bazel rules #116063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add mlir-query bazel rules #116063

merged 1 commit into from
Nov 21, 2024

Conversation

@j2kun
Copy link
Contributor

@j2kun j2kun commented Nov 13, 2024

I noticed there's no bazel query for mlir-query, unlike the other MLIR tools, so adding one.

@j2kun j2kun requested a review from jpienaar November 13, 2024 15:08
@llvmbot llvmbot added the bazel "Peripheral" support tier build system: utils/bazel label Nov 13, 2024
@github-actions
Copy link

github-actions bot commented Nov 13, 2024

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

@rupprecht
Copy link
Collaborator

rupprecht commented Nov 13, 2024

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off Keep my email addresses private setting in your account. See LLVM Discourse for more information.

Can you update the PR to take care of this? Otherwise LGTM.

@j2kun
Copy link
Contributor Author

j2kun commented Nov 13, 2024 •
edited
Loading

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off Keep my email addresses private setting in your account. See LLVM Discourse for more information.

Can you update the PR to take care of this? Otherwise LGTM.

Done

@j2kun
Copy link
Contributor Author

j2kun commented Nov 20, 2024

Ping @rupprecht

@rupprecht rupprecht merged commit 69cc3f0 into llvm:main Nov 21, 2024
6 checks passed
@rupprecht
Copy link
Collaborator

rupprecht commented Nov 21, 2024

Sorry, for some reason I thought I saw this already land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rupprecht rupprecht rupprecht approved these changes

@jpienaar jpienaar Awaiting requested review from jpienaar

@keith keith Awaiting requested review from keith keith is a code owner

Assignees

No one assigned

Labels

bazel "Peripheral" support tier build system: utils/bazel

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j2kun @rupprecht @llvmbot