Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlir] Fix typos in documentation #110869

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

tim-hoffman
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 2, 2024

@llvm/pr-subscribers-mlir-func

Author: Timothy Hoffman (tim-hoffman)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/110869.diff

3 Files Affected:

  • (modified) mlir/docs/DefiningDialects/Operations.md (+1-1)
  • (modified) mlir/docs/DefiningDialects/_index.md (+1-1)
  • (modified) mlir/include/mlir/Dialect/Func/IR/FuncOps.td (+1-1)
diff --git a/mlir/docs/DefiningDialects/Operations.md b/mlir/docs/DefiningDialects/Operations.md
index c252d9caf98eba..d93c0e7146011c 100644
--- a/mlir/docs/DefiningDialects/Operations.md
+++ b/mlir/docs/DefiningDialects/Operations.md
@@ -756,7 +756,7 @@ The available directives are as follows:
 
 *   `ref ( input )`
 
-    -   Represents a reference to the a variable or directive, that must have
+    -   Represents a reference to a variable or directive, that must have
         already been resolved, that may be used as a parameter to a `custom`
         directive.
     -   Used to pass previously parsed entities to custom directives.
diff --git a/mlir/docs/DefiningDialects/_index.md b/mlir/docs/DefiningDialects/_index.md
index 83070b616d0ef7..5196092dfbda11 100644
--- a/mlir/docs/DefiningDialects/_index.md
+++ b/mlir/docs/DefiningDialects/_index.md
@@ -133,7 +133,7 @@ void MyOp::setOtherValue(StringAttr newValue);
 
 ### Dependent Dialects
 
-MLIR has a very large ecosystem, and contains dialects that server many different purposes. It
+MLIR has a very large ecosystem, and contains dialects that serve many different purposes. It
 is quite common, given the above, that dialects may want to reuse certain components from other
 dialects. This may mean generating operations from those dialects during canonicalization, reusing
 attributes or types, etc. When a dialect has a dependency on another, i.e. when it constructs and/or
diff --git a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
index cca0008cbc2633..22efe15aa83a50 100644
--- a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
+++ b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
@@ -251,7 +251,7 @@ def FuncOp : Func_Op<"func", [
 
     // A function that returns its argument twice:
     func.func @count(%x: i64) -> (i64, i64)
-      attributes {fruit: "banana"} {
+      attributes {fruit = "banana"} {
       return %x, %x: i64, i64
     }
 

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 2, 2024

@llvm/pr-subscribers-mlir

Author: Timothy Hoffman (tim-hoffman)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/110869.diff

3 Files Affected:

  • (modified) mlir/docs/DefiningDialects/Operations.md (+1-1)
  • (modified) mlir/docs/DefiningDialects/_index.md (+1-1)
  • (modified) mlir/include/mlir/Dialect/Func/IR/FuncOps.td (+1-1)
diff --git a/mlir/docs/DefiningDialects/Operations.md b/mlir/docs/DefiningDialects/Operations.md
index c252d9caf98eba..d93c0e7146011c 100644
--- a/mlir/docs/DefiningDialects/Operations.md
+++ b/mlir/docs/DefiningDialects/Operations.md
@@ -756,7 +756,7 @@ The available directives are as follows:
 
 *   `ref ( input )`
 
-    -   Represents a reference to the a variable or directive, that must have
+    -   Represents a reference to a variable or directive, that must have
         already been resolved, that may be used as a parameter to a `custom`
         directive.
     -   Used to pass previously parsed entities to custom directives.
diff --git a/mlir/docs/DefiningDialects/_index.md b/mlir/docs/DefiningDialects/_index.md
index 83070b616d0ef7..5196092dfbda11 100644
--- a/mlir/docs/DefiningDialects/_index.md
+++ b/mlir/docs/DefiningDialects/_index.md
@@ -133,7 +133,7 @@ void MyOp::setOtherValue(StringAttr newValue);
 
 ### Dependent Dialects
 
-MLIR has a very large ecosystem, and contains dialects that server many different purposes. It
+MLIR has a very large ecosystem, and contains dialects that serve many different purposes. It
 is quite common, given the above, that dialects may want to reuse certain components from other
 dialects. This may mean generating operations from those dialects during canonicalization, reusing
 attributes or types, etc. When a dialect has a dependency on another, i.e. when it constructs and/or
diff --git a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
index cca0008cbc2633..22efe15aa83a50 100644
--- a/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
+++ b/mlir/include/mlir/Dialect/Func/IR/FuncOps.td
@@ -251,7 +251,7 @@ def FuncOp : Func_Op<"func", [
 
     // A function that returns its argument twice:
     func.func @count(%x: i64) -> (i64, i64)
-      attributes {fruit: "banana"} {
+      attributes {fruit = "banana"} {
       return %x, %x: i64, i64
     }
 

@MacDue MacDue changed the title fix typos in documentation [mlir] Fix typos in documentation Oct 12, 2024
@MacDue MacDue merged commit 02f42a7 into llvm:main Oct 12, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants