Don't build MLIRExecutionEngineShared on Windows #109524
Conversation
|
@llvm/pr-subscribers-mlir-execution-engine @llvm/pr-subscribers-mlir Author: None (Zentrik) ChangesIt doesn't currently build on windows, see #106859. Full diff: https://github.com/llvm/llvm-project/pull/109524.diff 1 Files Affected:
diff --git a/mlir/lib/ExecutionEngine/CMakeLists.txt b/mlir/lib/ExecutionEngine/CMakeLists.txt
index a091944b9ee7df..81ebc05e9eba59 100644
--- a/mlir/lib/ExecutionEngine/CMakeLists.txt
+++ b/mlir/lib/ExecutionEngine/CMakeLists.txt
@@ -97,7 +97,7 @@ add_mlir_library(MLIRExecutionEngine
MLIRTargetLLVMIRExport
)
-if(LLVM_BUILD_LLVM_DYLIB)
+if(LLVM_BUILD_LLVM_DYLIB AND NOT (WIN32 OR MINGW OR CYGWIN))
# Build a shared library for the execution engine. Some downstream projects
# use this library to build their own CPU runners while preserving dynamic
# linkage.
|
|
|
It doesn't currently build on windows, see llvm#106859.
Zentrik
force-pushed
the
workaround-106859
branch
from
c5a5df8
to
b6f9e3c
Compare
|
Gentle bump to get this reviewed 🙂 |
|
@Dinistro does this look fine? I suspect this is not an issue with my setup. |
|
Sorry for not getting back to you, this was somehow lost in my notifications. This seems reasonable, but maybe add acomment that the underlying issue is unclear. |
|
Done, if you're happy with this could you merge it as well (I don't have commit rights) |
Please request review in the future. I did not get any notification on this until you guys pinged me explicitly. |
Unfortunately, I don't seem to have those rights either but no worries. |
This disabled the build of `MLIRExecutionEngineShared` because this causes linkage issues in windows for currently unknown reasons. Related issue: llvm#106859. (cherry picked from commit 74e1062)
This disabled the build of `MLIRExecutionEngineShared` because this causes linkage issues in windows for currently unknown reasons. Related issue: llvm#106859. (cherry picked from commit 74e1062)
It doesn't currently build on windows, see #106859.