Win release packaging: Don't try to use rpmalloc for 32-bit x86 #106969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aganea
approved these changes
Sep 2, 2024
Member
aganea
left a comment
aganea
left a comment
There was a problem hiding this comment.
Sounds good, only 64-bit was intended initially.
Collaborator
Author
|
/cherry-pick ef26afc |
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 2, 2024
…#106969) because that doesn't work (results in `LINK : error LNK2001: unresolved external symbol malloc`). Based on the title of llvm#91862 it was only intended for use in 64-bit builds. (cherry picked from commit ef26afc)
Member
|
/pull-request #106985 |
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 3, 2024
…#106969) because that doesn't work (results in `LINK : error LNK2001: unresolved external symbol malloc`). Based on the title of llvm#91862 it was only intended for use in 64-bit builds. (cherry picked from commit ef26afc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because that doesn't work (results in
LINK : error LNK2001: unresolved external symbol malloc).Based on the title of #91862 it was only intended for use in 64-bit builds.