Attempt to fix: Sporadic Test Failure in thread.condition.condvarany/notify_one.pass.cpp #106880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am creating this draft PR to address the sporadic test failure in
thread.condition.condvarany/notify_one.pass.cpp
within the LLVM
libcxx
test suite. The issue stems from timing assumptions that cause the test to fail intermittently in both internal and external CI environments.I have previously worked in Microsoft STL's repository to unskip some of these sporadic tests.
Context:
The proposed fix adapts the approach used in the
notify_all test
(Issue #95944 and PR #97622 ) to enhance reliability by ensuring synchronization without relying on specific timing. This change should reduce or eliminate the occurrence of sporadic failures in this test.I was not able to find any issue raised for
notify_one.pass
issue similar tonotify_all.pass
issue, should I raise one to bind with this PR as well?I am seeking advice on this so adding a few people here
Please suggest @EugeneZelenko @lattner @topperc @shiltian @nikic @tbaederr please suggest.