Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix: Sporadic Test Failure in thread.condition.condvarany/notify_one.pass.cpp #106880

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arup-Chauhan
Copy link

@Arup-Chauhan Arup-Chauhan commented Sep 1, 2024

Hello, I am creating this draft PR to address the sporadic test failure in thread.condition.condvarany/notify_one.pass.cpp
within the LLVM libcxx test suite. The issue stems from timing assumptions that cause the test to fail intermittently in both internal and external CI environments.

I have previously worked in Microsoft STL's repository to unskip some of these sporadic tests.

Context:

The proposed fix adapts the approach used in the notify_all test (Issue #95944 and PR #97622 ) to enhance reliability by ensuring synchronization without relying on specific timing. This change should reduce or eliminate the occurrence of sporadic failures in this test.

I was not able to find any issue raised for notify_one.pass issue similar to notify_all.pass issue, should I raise one to bind with this PR as well?

I am seeking advice on this so adding a few people here
Please suggest @EugeneZelenko @lattner @topperc @shiltian @nikic @tbaederr please suggest.

Copy link

github-actions bot commented Sep 1, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant