[AVR] Fix LLD test #106739
Merged
[AVR] Fix LLD test #106739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @aykevl |
Member
|
@llvm/pr-subscribers-lld Author: Patryk Wychowaniec (Patryk27) ChangesSince we don't generate relocations for those, it doesn't make sense to assert them here; fallout of #106722. Full diff: https://github.com/llvm/llvm-project/pull/106739.diff 1 Files Affected:
diff --git a/lld/test/ELF/avr-reloc.s b/lld/test/ELF/avr-reloc.s
index ec088eaa149d01..41c32580f63a1c 100644
--- a/lld/test/ELF/avr-reloc.s
+++ b/lld/test/ELF/avr-reloc.s
@@ -76,32 +76,6 @@ adiw r24, b ; R_AVR_6_ADIW
in r20, b ; R_AVR_PORT6
sbic b, 1 ; R_AVR_PORT5
-.section .PCREL,"ax",@progbits
-; CHECK-LABEL: section .PCREL
-; CHECK: rjmp .+30
-; CHECK-NEXT: rjmp .-36
-; CHECK-NEXT: breq .+26
-; CHECK-NEXT: breq .-40
-; CHECK-NEXT: rjmp .-4096
-; CHECK-NEXT: rjmp .+4094
-; CHECK-NEXT: rjmp .+4094
-; CHECK-NEXT: rjmp .-4096
-; CHECK-NEXT: breq .-128
-; CHECK-NEXT: breq .+126
-; HEX-LABEL: section .PCREL:
-; HEX-NEXT: 0fc0eecf 69f061f3
-foo:
-rjmp foo + 32 ; R_AVR_13_PCREL
-rjmp foo - 32 ; R_AVR_13_PCREL
-breq foo + 32 ; R_AVR_7_PCREL
-breq foo - 32 ; R_AVR_7_PCREL
-rjmp 1f - 4096 $ 1: ; R_AVR_13_PCREL
-rjmp 1f + 4094 $ 1: ; R_AVR_13_PCREL
-rjmp 1f - 4098 $ 1: ; R_AVR_13_PCREL (overflow)
-rjmp 1f + 4096 $ 1: ; R_AVR_13_PCREL (overflow)
-breq 1f - 128 $ 1: ; R_AVR_7_PCREL
-breq 1f + 126 $ 1: ; R_AVR_7_PCREL
-
.section .LDSSTS,"ax",@progbits
; CHECK-LABEL: section .LDSSTS:
; CHECK: lds r20, 0x1e
|
Member
|
@llvm/pr-subscribers-lld-elf Author: Patryk Wychowaniec (Patryk27) ChangesSince we don't generate relocations for those, it doesn't make sense to assert them here; fallout of #106722. Full diff: https://github.com/llvm/llvm-project/pull/106739.diff 1 Files Affected:
diff --git a/lld/test/ELF/avr-reloc.s b/lld/test/ELF/avr-reloc.s
index ec088eaa149d01..41c32580f63a1c 100644
--- a/lld/test/ELF/avr-reloc.s
+++ b/lld/test/ELF/avr-reloc.s
@@ -76,32 +76,6 @@ adiw r24, b ; R_AVR_6_ADIW
in r20, b ; R_AVR_PORT6
sbic b, 1 ; R_AVR_PORT5
-.section .PCREL,"ax",@progbits
-; CHECK-LABEL: section .PCREL
-; CHECK: rjmp .+30
-; CHECK-NEXT: rjmp .-36
-; CHECK-NEXT: breq .+26
-; CHECK-NEXT: breq .-40
-; CHECK-NEXT: rjmp .-4096
-; CHECK-NEXT: rjmp .+4094
-; CHECK-NEXT: rjmp .+4094
-; CHECK-NEXT: rjmp .-4096
-; CHECK-NEXT: breq .-128
-; CHECK-NEXT: breq .+126
-; HEX-LABEL: section .PCREL:
-; HEX-NEXT: 0fc0eecf 69f061f3
-foo:
-rjmp foo + 32 ; R_AVR_13_PCREL
-rjmp foo - 32 ; R_AVR_13_PCREL
-breq foo + 32 ; R_AVR_7_PCREL
-breq foo - 32 ; R_AVR_7_PCREL
-rjmp 1f - 4096 $ 1: ; R_AVR_13_PCREL
-rjmp 1f + 4094 $ 1: ; R_AVR_13_PCREL
-rjmp 1f - 4098 $ 1: ; R_AVR_13_PCREL (overflow)
-rjmp 1f + 4096 $ 1: ; R_AVR_13_PCREL (overflow)
-breq 1f - 128 $ 1: ; R_AVR_7_PCREL
-breq 1f + 126 $ 1: ; R_AVR_7_PCREL
-
.section .LDSSTS,"ax",@progbits
; CHECK-LABEL: section .LDSSTS:
; CHECK: lds r20, 0x1e
|
llvmbot
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 3, 2024
Since we don't generate relocations for those, it doesn't make sense to assert them here; fallout of llvm#106722. (cherry picked from commit a3816b5)
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Sep 3, 2024
Since we don't generate relocations for those, it doesn't make sense to assert them here; fallout of llvm#106722. (cherry picked from commit a3816b5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we don't generate relocations for those, it doesn't make sense to assert them here; fallout of #106722.