release/19.x: [libclang] Fix symbol version of getBinaryOpcode functions (#101820)
#101824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Endilll What do you think about merging this PR to the release branch? |
|
@llvm/pr-subscribers-clang Author: None (llvmbot) ChangesBackport 2bae7ae Requested by: @Endilll Full diff: https://github.com/llvm/llvm-project/pull/101824.diff 1 Files Affected:
diff --git a/clang/tools/libclang/libclang.map b/clang/tools/libclang/libclang.map
index 91c329b5765d4..371fe512ce71c 100644
--- a/clang/tools/libclang/libclang.map
+++ b/clang/tools/libclang/libclang.map
@@ -54,8 +54,6 @@ LLVM_13 {
clang_Cursor_Evaluate;
clang_Cursor_getArgument;
clang_Cursor_getBriefCommentText;
- clang_Cursor_getBinaryOpcode;
- clang_Cursor_getBinaryOpcodeStr;
clang_Cursor_getCXXManglings;
clang_Cursor_getCommentRange;
clang_Cursor_getMangling;
@@ -430,6 +428,12 @@ LLVM_17 {
clang_getCursorUnaryOperatorKind;
};
+LLVM_19 {
+ global:
+ clang_Cursor_getBinaryOpcode;
+ clang_Cursor_getBinaryOpcodeStr;
+};
+
# Example of how to add a new symbol version entry. If you do add a new symbol
# version, please update the example to depend on the version you added.
# LLVM_X {
|
|
|
Endilll
approved these changes
Aug 3, 2024
…1820) llvm#98489 resurrected an [old patch](https://reviews.llvm.org/D10833) that was adding new libclang functions. That PR got merged with old `LLVM_13` symbol versions for new functions. This patch fixes this oversight. (cherry picked from commit 2bae7ae)
|
@Endilll (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2bae7ae
Requested by: @Endilll