workflows/release-binaries: Fetch composite actions outside of default workspace #100845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t workspace Otherwise, the checkout step will override them.
|
@llvm/pr-subscribers-github-workflow Author: Tom Stellard (tstellar) ChangesOtherwise, the checkout step will override them. Full diff: https://github.com/llvm/llvm-project/pull/100845.diff 1 Files Affected:
diff --git a/.github/workflows/release-binaries.yml b/.github/workflows/release-binaries.yml
index f7ed88ff03add..927eee3157739 100644
--- a/.github/workflows/release-binaries.yml
+++ b/.github/workflows/release-binaries.yml
@@ -156,11 +156,13 @@ jobs:
sparse-checkout: |
.github/workflows/
sparse-checkout-cone-mode: false
- path: workflows
+ # Check out outside of working directory so the source checkout doesn't
+ # remove it.
+ path: ../workflows
- name: Setup Stage
id: setup-stage
- uses: ./workflows/.github/workflows/release-binaries-setup-stage
+ uses: ../workflows/.github/workflows/release-binaries-setup-stage
- name: Checkout LLVM
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
@@ -194,7 +196,7 @@ jobs:
ls -ltr ${{ steps.setup-stage.outputs.build-prefix }}/build
- name: Save Stage
- uses: ./workflows/.github/workflows/release-binaries-save-stage
+ uses: ../workflows/.github/workflows/release-binaries-save-stage
with:
build-prefix: ${{ steps.setup-stage.outputs.build-prefix }}
|
|
The test failures with this are expected. I think this fix is ready to land. |
boomanaiden154
approved these changes
Jul 30, 2024
clementval
pushed a commit
to clementval/llvm-project
that referenced
this pull request
Jul 31, 2024
…t workspace (llvm#100845) Otherwise, the checkout step will override them.
tstellar
added a commit
to tstellar/llvm-project
that referenced
this pull request
Aug 3, 2024
…t workspace (llvm#100845) Otherwise, the checkout step will override them. (cherry picked from commit 41003ff)
tru
pushed a commit
to tstellar/llvm-project
that referenced
this pull request
Aug 5, 2024
…t workspace (llvm#100845) Otherwise, the checkout step will override them. (cherry picked from commit 41003ff)
banach-space
pushed a commit
to banach-space/llvm-project
that referenced
this pull request
Aug 7, 2024
…t workspace (llvm#100845) Otherwise, the checkout step will override them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the checkout step will override them.