Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
#include <bitset>
#include <cassert>
#include <cctype>
#include <cmath>
Comment thread
davemgreen marked this conversation as resolved.
Outdated
#include <cstdint>
#include <cstdlib>
#include <iterator>
Expand Down Expand Up @@ -1523,6 +1524,7 @@ AArch64TargetLowering::AArch64TargetLowering(const TargetMachine &TM,
setOperationAction(ISD::VECREDUCE_AND, VT, Custom);
setOperationAction(ISD::VECREDUCE_OR, VT, Custom);
setOperationAction(ISD::VECREDUCE_XOR, VT, Custom);
setOperationAction(ISD::OR, VT, Custom);

setOperationAction(ISD::SELECT_CC, VT, Expand);
setOperationAction(ISD::INSERT_VECTOR_ELT, VT, Custom);
Expand Down Expand Up @@ -13782,8 +13784,88 @@ static SDValue tryLowerToSLI(SDNode *N, SelectionDAG &DAG) {
return ResultSLI;
}

/// Try to lower the construction of a pointer alias mask to a WHILEWR.
/// The mask's enabled lanes represent the elements that will not overlap across one loop iteration.
/// This tries to match:
/// or (splat (setcc_lt (sub ptrA, ptrB), -(element_size - 1))),
/// (get_active_lane_mask 0, (div (sub ptrA, ptrB), element_size))
SDValue tryWhileWRFromOR(SDValue Op, SelectionDAG &DAG) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass Subtarget from the caller.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

if (!DAG.getSubtarget<AArch64Subtarget>().hasSVE2())
return SDValue();
auto LaneMask = Op.getOperand(0);
Comment thread
davemgreen marked this conversation as resolved.
Outdated
auto Splat = Op.getOperand(1);

if (LaneMask.getOpcode() != ISD::INTRINSIC_WO_CHAIN ||
Comment thread
davemgreen marked this conversation as resolved.
LaneMask.getConstantOperandVal(0) != Intrinsic::get_active_lane_mask ||
Splat.getOpcode() != ISD::SPLAT_VECTOR)
return SDValue();

auto Cmp = Splat.getOperand(0);
if (Cmp.getOpcode() != ISD::SETCC)
return SDValue();

CondCodeSDNode *Cond = dyn_cast<CondCodeSDNode>(Cmp.getOperand(2));
Comment thread
davemgreen marked this conversation as resolved.
Outdated
assert(Cond && "SETCC doesn't have a condition code");

auto ComparatorConst = dyn_cast<ConstantSDNode>(Cmp.getOperand(1));
if (!ComparatorConst || ComparatorConst->getSExtValue() > 0 ||
Cond->get() != ISD::CondCode::SETLT)
return SDValue();
unsigned CompValue = std::abs(ComparatorConst->getSExtValue());
unsigned EltSize = CompValue + 1;
if (!isPowerOf2_64(EltSize) || EltSize > 64)
Comment thread
davemgreen marked this conversation as resolved.
Outdated
return SDValue();

auto Diff = Cmp.getOperand(0);
if (Diff.getOpcode() != ISD::SUB || Diff.getValueType() != MVT::i64)
return SDValue();

auto LaneMaskConst = dyn_cast<ConstantSDNode>(LaneMask.getOperand(1));
if (!LaneMaskConst || LaneMaskConst->getZExtValue() != 0 ||
(EltSize != 1 && LaneMask.getOperand(2).getOpcode() != ISD::SRA))
return SDValue();

// An alias mask for i8 elements omits the division because it would just divide by 1
if (EltSize > 1) {
auto DiffDiv = LaneMask.getOperand(2);
auto DiffDivConst = dyn_cast<ConstantSDNode>(DiffDiv.getOperand(1));
if (!DiffDivConst || DiffDivConst->getZExtValue() != std::log2(EltSize))
return SDValue();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::log -> Log2_64 if it is integer.
Should something check DiffDiv.getOperand(0) == Diff?

@SamTebbs33 SamTebbs33 Jul 31, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is indeed a check of the divide operand missing. It's a bit more involved since Diff can be negative, so some extra selects and such are inserted to turn it positive before dividing. The 16 bit element case is a little different to the others and so needs some different matching. I hope I've explained it well enough in the comments in the commit I just pushed to address your suggestion.

} else if (LaneMask.getOperand(2) != Diff)
return SDValue();

auto StorePtr = Diff.getOperand(0);
auto ReadPtr = Diff.getOperand(1);

unsigned IntrinsicID = 0;
switch (EltSize) {
case 1:
IntrinsicID = Intrinsic::aarch64_sve_whilewr_b;
break;
case 2:
IntrinsicID = Intrinsic::aarch64_sve_whilewr_h;
break;
case 4:
IntrinsicID = Intrinsic::aarch64_sve_whilewr_s;
break;
case 8:
IntrinsicID = Intrinsic::aarch64_sve_whilewr_d;
break;
default:
return SDValue();
}
SDLoc DL(Op);
SDValue ID = DAG.getConstant(IntrinsicID, DL, MVT::i32);
auto N = DAG.getNode(ISD::INTRINSIC_WO_CHAIN, DL, Op.getValueType(), ID,
StorePtr, ReadPtr);
return N;
}

SDValue AArch64TargetLowering::LowerVectorOR(SDValue Op,
SelectionDAG &DAG) const {

if (SDValue SV = tryWhileWRFromOR(Op, DAG))
return SV;
if (useSVEForFixedLengthVectorVT(Op.getValueType(),
!Subtarget->isNeonAvailable()))
return LowerToScalableOp(Op, DAG);
Expand Down
Loading