Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Fix version-check workflow #100090

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[Infra] Fix version-check workflow #100090

merged 1 commit into from
Jul 23, 2024

Conversation

tru
Copy link
Collaborator

@tru tru commented Jul 23, 2024

No description provided.

@tru tru added the infrastructure Bugs about LLVM infrastructure label Jul 23, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Jul 23, 2024

@llvm/pr-subscribers-github-workflow

Author: Tobias Hieta (tru)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/100090.diff

1 Files Affected:

  • (modified) .github/workflows/version-check.yml (+1-1)
diff --git a/.github/workflows/version-check.yml b/.github/workflows/version-check.yml
index 4ce6119a407f5..894e07d323ca9 100644
--- a/.github/workflows/version-check.yml
+++ b/.github/workflows/version-check.yml
@@ -27,5 +27,5 @@ jobs:
 
       - name: Version Check
         run: |
-          version=$(grep -o 'LLVM_VERSION_\(MAJOR\|MINOR\|PATCH\) [0-9]\+' llvm/CMakeLists.txt  | cut -d ' ' -f 2 | tr "\n" "." | sed 's/.$//g')
+          version=$(grep -o 'LLVM_VERSION_\(MAJOR\|MINOR\|PATCH\) [0-9]\+' cmake/Modules/LLVMVersion.cmake  | cut -d ' ' -f 2 | tr "\n" "." | sed 's/.$//g')
           .github/workflows/version-check.py "$version"

Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tru tru merged commit a0971f0 into llvm:main Jul 23, 2024
8 checks passed
@tru tru deleted the tru/version_check_wf branch July 23, 2024 11:03
tru added a commit that referenced this pull request Jul 23, 2024
sgundapa pushed a commit to sgundapa/upstream_effort that referenced this pull request Jul 23, 2024
yuxuanchen1997 pushed a commit that referenced this pull request Jul 25, 2024
Summary: 

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D60251225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github:workflow infrastructure Bugs about LLVM infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants