Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Add git CLI to Linux container #82646

Closed
sudonatalie opened this issue Feb 22, 2024 · 5 comments · Fixed by #82687
Closed

[infra] Add git CLI to Linux container #82646

sudonatalie opened this issue Feb 22, 2024 · 5 comments · Fixed by #82687
Assignees
Labels
backend:SPIR-V infrastructure Bugs about LLVM infrastructure

Comments

@sudonatalie
Copy link
Member

Since #81349 the SPIR-V Tests workflow has been failing with /bin/sh: 1: git: not found.

@sudonatalie sudonatalie added infrastructure Bugs about LLVM infrastructure backend:SPIR-V labels Feb 22, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 22, 2024

@llvm/issue-subscribers-infrastructure

Author: Natalie Chouinard (sudonatalie)

Since #81349 the [SPIR-V Tests](https://github.com/llvm/llvm-project/actions/workflows/spirv-tests.yml) workflow has been failing with `/bin/sh: 1: git: not found`.

@sudonatalie
Copy link
Member Author

@tstellar Can you take a look at this or help point me to an appropriate config file? I can't seem to figure out where packages would be managed for the container.

@tstellar tstellar self-assigned this Feb 22, 2024
@tstellar
Copy link
Collaborator

@sudonatalie The dockerfile for the container is here: https://github.com/llvm/llvm-project/blob/main/.github/workflows/containers/github-action-ci/stage2.Dockerfile

But why is the SPIR-V build trying to clone and build code from another repo? Is that used for testing?

@sudonatalie
Copy link
Member Author

@tstellar Yes, it's a test-only dependency on an external tool that does some additional validation of test output. It's off by default but we've enabled it on the bots because it can catch certain classes of regressions that are otherwise difficult to identify.

sudonatalie added a commit to sudonatalie/llvm-project that referenced this issue Feb 22, 2024
@boomanaiden154
Copy link
Contributor

I remember adding git to the container at some point. It looks like I added it to the toolchain build container rather than the image that actually gets used in the CI jobs.

sudonatalie added a commit to sudonatalie/llvm-project that referenced this issue Mar 4, 2024
sudonatalie added a commit that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:SPIR-V infrastructure Bugs about LLVM infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants