-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libcxxabi] HAS_THREAD_LOCAL is not defined by cmake #78207
Comments
Do you folks know if |
@ldionne Can't say about other platforms but it's available on |
Hmm, this is related to https://reviews.llvm.org/D138461. I'd be tempted to do the naive thing and try landing https://reviews.llvm.org/D138461 again. |
This was previously guarded by HAS_THREAD_LOCAL, which was never set by CMake and had to be specified manually. Android has been setting this to solve android/ndk#1200 [1], but every compiler and platform libc++abi supports should have thread_local by now, so we can just get rid of the fallback implementation and simplify things significantly (including removing the now unused fallback calloc). This is a re-application of https://reviews.llvm.org/D138461. Fixes llvm#78207. [1]: https://android-review.googlesource.com/c/toolchain/llvm-project/+/1285596 Co-Authored-By: Shoaib Meenai <[email protected]>
This was previously guarded by HAS_THREAD_LOCAL, which was never set by CMake and had to be specified manually. Android has been setting this to solve android/ndk#1200 [1], but every compiler and platform libc++abi supports should have thread_local by now, so we can just get rid of the fallback implementation and simplify things significantly (including removing the now unused fallback calloc). This is a re-application of https://reviews.llvm.org/D138461. Fixes llvm#78207. [1]: https://android-review.googlesource.com/c/toolchain/llvm-project/+/1285596 Co-Authored-By: Shoaib Meenai <[email protected]>
This was previously guarded by HAS_THREAD_LOCAL, which was never set by CMake and had to be specified manually. Android has been setting this to solve android/ndk#1200 [1], but every compiler and platform libc++abi supports should have thread_local by now, so we can just get rid of the fallback implementation and simplify things significantly (including removing the now unused fallback calloc). This is a re-application of https://reviews.llvm.org/D138461. Fixes llvm#78207. [1]: https://android-review.googlesource.com/c/toolchain/llvm-project/+/1285596 Co-Authored-By: Shoaib Meenai <[email protected]>
This was previously guarded by HAS_THREAD_LOCAL, which was never set by CMake and had to be specified manually. Android has been setting this to solve android/ndk#1200 [1], but every compiler and platform libc++abi supports should have thread_local by now, so we can just get rid of the fallback implementation and simplify things significantly (including removing the now unused fallback calloc). This is a re-application of https://reviews.llvm.org/D138461. Fixes llvm#78207. [1]: https://android-review.googlesource.com/c/toolchain/llvm-project/+/1285596 Co-Authored-By: Shoaib Meenai <[email protected]>
…or exception storage Previously, we'd use HAS_THREAD_LOCAL which was never defined. Hence, we'd basically never use the code path where we use thread_local. Fixes llvm#78207
libcxxabi/src/cxa_exception_storage.cpp
contain a check forHAS_THREAD_LOCAL
, but the flags is set bycompiler-rt/lib/fuzzer/CMakeLists.txt
. This cmake script is not used in normal build of libcxxabi.Maybe it should be replaced by
__has_feature(cxx_thread_local)
?See also: https://reviews.llvm.org/D155278
The text was updated successfully, but these errors were encountered: