Stumbling over semantics of AssertionInfoMatcher::CheckMessageMatches

[hawkinsw]

I just got bit by a nasty oddity in the semantics of AssertionInfoMatcher::CheckMessageMatches where

// Allow any match

(see [1] below)

was not the behavior that I expected.

I was getting a positive match for

nnot increment an iterator already at the end.

when attempting to check that

Cannot increment an iterator already at the end.

was the assertion's message.

Would there be any willingness to change the semantics of the this matcher? Maybe "anchored at the beginning"? Or "must match entirely"?

If so, I am happy to take the lead on making that change. I hope that this is not a bother.

[1]

llvm-project/libcxx/test/support/check_assertion.h

Line 92 in 21a784f

// Allow any match