clang-format performs SortIncludes even if DisableFormat: true

[vvuk]

Bugzilla Link	35099
Resolution	FIXED
Resolved on	May 04, 2021 11:05
Version	5.0
OS	Windows NT
CC	@NN--
Fixed by commit(s)	61dc0f2

Extended Description

DisableFormat: true doesn't turn off SortIncludes (clang-format 5.0):

$ printf '#include \n#include \n' | clang-format -assume-filename=test.cpp -style='{DisableFormat: true}'
#include
#include

It needs to be explicitly specified as false to turn it off:

$ printf '#include \n#include \n' | clang-format -assume-filename=test.cpp -style='{DisableFormat: true, SortIncludes: false}'
#include
#include

Not sure if it is intentional or not -- was surprising at the very least.

[NN--]

Issue persist clang-format 11.0.

[llvmbot]

Seems confusing to me as well, put in a quick hotfix https://reviews.llvm.org/D101628

[llvmbot]

Fixed in 61dc0f2