Skip to content

Commit

Permalink
Corrects previously incorrect $sp change in MipsCompilationCallback.
Browse files Browse the repository at this point in the history
The address for $sp, and addresses for sdc1/ldc1 must be 8-byte aligned

Patch by Petar Jovanovic.

llvm-svn: 142930
  • Loading branch information
bcardosolopes committed Oct 25, 2011
1 parent b75951f commit c0ecd1f
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions llvm/lib/Target/Mips/MipsJITInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ void MipsCompilationCallback();
".globl " ASMPREFIX "MipsCompilationCallback\n"
ASMPREFIX "MipsCompilationCallback:\n"
".ent " ASMPREFIX "MipsCompilationCallback\n"
".frame $29, 32, $31\n"
".frame $sp, 32, $ra\n"
".set noreorder\n"
".cpload $t9\n"

"addiu $sp, $sp, -60\n"
"addiu $sp, $sp, -64\n"
".cprestore 16\n"

// Save argument registers a0, a1, a2, a3, f12, f14 since they may contain
Expand All @@ -76,8 +76,8 @@ void MipsCompilationCallback();
"sw $a3, 32($sp)\n"
"sw $ra, 36($sp)\n"
"sw $t8, 40($sp)\n"
"sdc1 $f12, 44($sp)\n"
"sdc1 $f14, 52($sp)\n"
"sdc1 $f12, 48($sp)\n"
"sdc1 $f14, 56($sp)\n"

// t8 points at the end of function stub. Pass the beginning of the stub
// to the MipsCompilationCallbackC.
Expand All @@ -92,9 +92,9 @@ void MipsCompilationCallback();
"lw $a3, 32($sp)\n"
"lw $ra, 36($sp)\n"
"lw $t8, 40($sp)\n"
"ldc1 $f12, 44($sp)\n"
"ldc1 $f14, 52($sp)\n"
"addiu $sp, $sp, 60\n"
"ldc1 $f12, 48($sp)\n"
"ldc1 $f14, 56($sp)\n"
"addiu $sp, $sp, 64\n"

// Jump to the (newly modified) stub to invoke the real function.
"addiu $t8, $t8, -16\n"
Expand Down

0 comments on commit c0ecd1f

Please sign in to comment.