Skip to content

Commit

Permalink
[DWARFLinker] Avoid repeated hash lookups (NFC) (#109604)
Browse files Browse the repository at this point in the history
  • Loading branch information
kazutakahirata authored Sep 23, 2024
1 parent cee6509 commit 9a33488
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions llvm/lib/DWARFLinker/Parallel/DWARFLinkerTypeUnit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -287,12 +287,12 @@ uint32_t TypeUnit::addFileNameIntoLinetable(StringEntry *Dir,
}

uint32_t FileIdx = 0;
FilenamesMapTy::iterator FileEntry = FileNamesMap.find({FileName, DirIdx});
if (FileEntry == FileNamesMap.end()) {
auto [FileEntry, Inserted] = FileNamesMap.try_emplace({FileName, DirIdx});
if (Inserted) {
// We currently do not support more than UINT32_MAX files.
assert(LineTable.Prologue.FileNames.size() < UINT32_MAX);
FileIdx = LineTable.Prologue.FileNames.size();
FileNamesMap.insert({{FileName, DirIdx}, FileIdx});
FileEntry->second = FileIdx;
LineTable.Prologue.FileNames.push_back(DWARFDebugLine::FileNameEntry());
LineTable.Prologue.FileNames.back().Name = DWARFFormValue::createFromPValue(
dwarf::DW_FORM_string, FileName->getKeyData());
Expand Down

0 comments on commit 9a33488

Please sign in to comment.