-
Notifications
You must be signed in to change notification settings - Fork 11.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[DebugInfo] Correct the line attribution for IF branches (#108300)
An 'if' statement introduces a scope, but in some cases the conditional branch to the then/else blocks had a debug-info attribution that did not include the scope. This led to some inefficiency in the DWARF line table.
- Loading branch information
Showing
2 changed files
with
46 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// RUN: %clang_cc1 -debug-info-kind=limited -gno-column-info -triple=x86_64-pc-linux -emit-llvm %s -o - | FileCheck %s | ||
|
||
// The important thing is that the compare and the conditional branch have | ||
// locs with the same scope (the lexical block for the 'if'). By turning off | ||
// column info, they end up with the same !dbg record, which halves the number | ||
// of checks to verify the scope. | ||
|
||
int c = 2; | ||
|
||
int f() { | ||
#line 100 | ||
if (int a = 5; a > c) | ||
return 1; | ||
return 0; | ||
} | ||
// CHECK-LABEL: define {{.*}} @_Z1fv() | ||
// CHECK: = icmp {{.*}} !dbg [[F_CMP:![0-9]+]] | ||
// CHECK-NEXT: br i1 {{.*}} !dbg [[F_CMP]] | ||
|
||
int g() { | ||
#line 200 | ||
if (int a = f()) | ||
return 2; | ||
return 3; | ||
} | ||
// CHECK-LABEL: define {{.*}} @_Z1gv() | ||
// CHECK: = icmp {{.*}} !dbg [[G_CMP:![0-9]+]] | ||
// CHECK-NEXT: br i1 {{.*}} !dbg [[G_CMP]] | ||
|
||
int h() { | ||
#line 300 | ||
if (c > 3) | ||
return 4; | ||
return 5; | ||
} | ||
// CHECK-LABEL: define {{.*}} @_Z1hv() | ||
// CHECK: = icmp {{.*}} !dbg [[H_CMP:![0-9]+]] | ||
// CHECK-NEXT: br i1 {{.*}} !dbg [[H_CMP]] | ||
|
||
// CHECK-DAG: [[F_CMP]] = !DILocation(line: 100, scope: [[F_SCOPE:![0-9]+]] | ||
// CHECK-DAG: [[F_SCOPE]] = distinct !DILexicalBlock({{.*}} line: 100) | ||
// CHECK-DAG: [[G_CMP]] = !DILocation(line: 200, scope: [[G_SCOPE:![0-9]+]] | ||
// CHECK-DAG: [[G_SCOPE]] = distinct !DILexicalBlock({{.*}} line: 200) | ||
// CHECK-DAG: [[H_CMP]] = !DILocation(line: 300, scope: [[H_SCOPE:![0-9]+]] | ||
// CHECK-DAG: [[H_SCOPE]] = distinct !DILexicalBlock({{.*}} line: 300) |