Ignore merge commits in PR Emailer #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging main into a PR, the merge commits bring in changes to files in all subprojects. Essentially this means that any PR that merges main ends up sending mails to all mailing lists. When iterating over the commits in the PR, skip the merge commits. If the merge commits contains functional changes other than the pure merge, the same changed files should be present in other commits anyway, if the changes are due to conflicts.
Member
Author
|
@mstorsjo I'll try to see what I can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging main into a PR, the merge commits bring in changes to files in all subprojects. Essentially this means that any PR that merges main ends up sending mails to all mailing lists.
When iterating over the commits in the PR, skip the merge commits. If the merge commits contains functional changes other than the pure merge, the same changed files should be present in other commits anyway, if the changes are due to conflicts.