Skip to content

Conversation

@gitoleg
Copy link
Collaborator

@gitoleg gitoleg commented Oct 31, 2023

As discussed in #279, we split CIRGenBuilder in two parts, which make some of the helpers usable outside of the CodeGen part.
Basically, I placed casts and binary operations into a separate class, CIRBaseBuilder. Later, it can be extended with another helpers. But right now an idea to have a state less builder as a base one.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcardosolopes bcardosolopes merged commit 7c89c92 into llvm:main Nov 1, 2023
lanza pushed a commit that referenced this pull request Dec 20, 2023
As discussed in #279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
lanza pushed a commit that referenced this pull request Jan 29, 2024
As discussed in #279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
lanza pushed a commit that referenced this pull request Mar 23, 2024
As discussed in #279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
As discussed in llvm#279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
As discussed in llvm#279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
lanza pushed a commit that referenced this pull request Apr 29, 2024
As discussed in #279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
lanza pushed a commit that referenced this pull request Apr 29, 2024
As discussed in #279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
As discussed in llvm#279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
lanza pushed a commit that referenced this pull request Apr 29, 2024
As discussed in #279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
As discussed in llvm#279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
As discussed in llvm#279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
As discussed in llvm#279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
lanza pushed a commit that referenced this pull request Nov 5, 2024
As discussed in #279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
lanza pushed a commit that referenced this pull request Mar 18, 2025
As discussed in #279, we split `CIRGenBuilder` in two parts, which make
some of the helpers usable outside of the `CodeGen` part.
Basically, I placed casts and binary operations into a separate class,
`CIRBaseBuilder`. Later, it can be extended with another helpers. But
right now an idea to have a state less builder as a base one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants