Skip to content

[CIR][CIRGen] CIR generation for bitfields. Fixes #13 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcardosolopes merged 20 commits into from
Sep 14, 2023
Merged

[CIR][CIRGen] CIR generation for bitfields. Fixes #13 #233

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
d9df914
[CIR][CIRGen] adds bitfields support. Fixes #13
gitoleg Aug 14, 2023
b717c07
adds two simple tests
gitoleg Aug 23, 2023
6d1bd16
refactoring, added helpers
gitoleg Aug 24, 2023
f7fffd4
wip
gitoleg Aug 24, 2023
7fe5ae1
removed unrelated code
gitoleg Aug 24, 2023
ec3908a
clang format applied
gitoleg Aug 24, 2023
7dbf3c0
minor fixes
gitoleg Aug 24, 2023
b173f2f
Merge remote-tracking branch 'upstream/main' into handle-bitfields
gitoleg Aug 25, 2023
d9ae0b0
merge with main
gitoleg Aug 29, 2023
df803b6
use GetMemberOp
gitoleg Aug 31, 2023
fba70cc
tests passed
gitoleg Aug 31, 2023
38cd86e
wip
gitoleg Aug 31, 2023
f090fb5
refactored tests
gitoleg Aug 31, 2023
f8a49f1
wip
gitoleg Aug 31, 2023
5964289
fixed tests, use powerOfTwo storage
gitoleg Sep 4, 2023
74bde29
Merge remote-tracking branch 'upstream/main' into handle-bitfields
gitoleg Sep 4, 2023
2c52145
adds a new Unimplemented feature: scalarRangeCheck
gitoleg Sep 6, 2023
e05acd5
merge with main
gitoleg Sep 9, 2023
1ac0544
minor stylish changes
gitoleg Sep 9, 2023
d0d860e
Merge remote-tracking branch 'upstream/main' into handle-bitfields
gitoleg Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 50 additions & 1 deletion clang/test/CIR/CodeGen/bitfields.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,53 @@ void m() {
}

// CHECK: !ty_22struct2Eanon22 = !cir.struct<"struct.anon", !u32i, #cir.recdecl.ast>
// CHECK: !ty_22struct2E__long22 = !cir.struct<"struct.__long", !ty_22struct2Eanon22, !u32i, !cir.ptr<!u32i>>
// CHECK: !ty_22struct2E__long22 = !cir.struct<"struct.__long", !ty_22struct2Eanon22, !u32i, !cir.ptr<!u32i>>


struct S {
int a : 4;
int b : 27;
int c : 17;
int d : 2;
int e : 15;
}; // 65 bits in total, i.e. mote than 64

void store_field() {
S s;
s.a = 3;
}

// CHECK: cir.func @_Z11store_field
// CHECK: %1 = cir.const(#cir.int<3> : !s32i) : !s32i
// CHECK: %2 = cir.cast(bitcast, %0 : !cir.ptr<!ty_22struct2ES22>), !cir.ptr<!u32i>
// CHECK: %3 = cir.cast(integral, %1 : !s32i), !u32i
// CHECK: %4 = cir.load %2 : cir.ptr <!u32i>, !u32i
// CHECK: %5 = cir.const(#cir.int<15> : !u32i) : !u32i
// CHECK: %6 = cir.binop(and, %3, %5) : !u32i
// CHECK: %7 = cir.const(#cir.int<4294967280> : !u32i) : !u32i
// CHECK: %8 = cir.binop(and, %4, %7) : !u32i
// CHECK: %9 = cir.binop(or, %8, %6) : !u32i
// CHECK: cir.store %9, %2 : !u32i, cir.ptr <!u32i>

void store_neg_field() {
S s;
s.d = -1;
}

// CHECK: cir.func @_Z15store_neg_field
// CHECK: %1 = cir.const(#cir.int<1> : !s32i) : !s32i
// CHECK: %2 = cir.unary(minus, %1) : !s32i, !s32i
// CHECK: %3 = "cir.struct_element_addr"(%0) {member_index = 1 : index, member_name = "d"} : (!cir.ptr<!ty_22struct2ES22>) -> !cir.ptr<!s32i>
// CHECK: %4 = cir.cast(bitcast, %3 : !cir.ptr<!s32i>), !cir.ptr<!u24i>
// CHECK: %5 = cir.cast(integral, %2 : !s32i), !u24i
// CHECK: %6 = cir.load %4 : cir.ptr <!u24i>, !u24i
// CHECK: %7 = cir.const(#cir.int<3> : !u24i) : !u24i
// CHECK: %8 = cir.binop(and, %5, %7) : !u24i
// CHECK: %9 = cir.const(#cir.int<17> : !u24i) : !u24i
// CHECK: %10 = cir.shift(left, %8 : !u24i, %9 : !u24i) -> !u24i
// CHECK: %11 = cir.const(#cir.int<16383999> : !u24i) : !u24i
// CHECK: %12 = cir.binop(and, %6, %11) : !u24i
// CHECK: %13 = cir.binop(or, %12, %10) : !u24i
// CHECK: cir.store %13, %4 : !u24i, cir.ptr <!u24i>

// 16383999 decimal = 1111 1001 1111 1111 1111 1111 binary