[CIR] Fix error in cir.label when using cir.br in entry block #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andres-Salamanca
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Andres-Salamanca
added a commit
to llvm/llvm-project
that referenced
this pull request
Oct 15, 2025
This PR fixes an error I found while working on cir.indirectbr. The issue occurs when a branching operator points to the entry block LLVM’s verifier does not allow this. This PR is the same as the one I submitted in the incubator:llvm/clangir#1939
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 15, 2025
…ock (#163280) This PR fixes an error I found while working on cir.indirectbr. The issue occurs when a branching operator points to the entry block LLVM’s verifier does not allow this. This PR is the same as the one I submitted in the incubator:llvm/clangir#1939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error I found while working on
cir.indirectbr. The issue occurs when a branching operator points to the entry block LLVM’s verifier does not allow thisclangir/mlir/lib/IR/Verifier.cpp
Lines 205 to 208 in 10f2ee1
Previously, in
cir.label, when building a block, we only checked if the current block was not empty. Now, we also check if we are in the entry block. If we are, a new block is created instead.This change also helps emit IR that is closer to the classic code behavior.