[CIR] Add dedicated CIR op for setjmp #1853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badumbatish
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
bcardosolopes
changed the title
andykaylor
reviewed
Aug 25, 2025
bcardosolopes
requested changes
Aug 26, 2025
tommymcm
reviewed
Aug 26, 2025
Collaborator
tommymcm
left a comment
tommymcm
left a comment
There was a problem hiding this comment.
A few more nits on the description. A little confused by the current one.
Contributor
Author
yep on it |
tommymcm
reviewed
Aug 27, 2025
tommymcm
reviewed
Aug 29, 2025
Collaborator
tommymcm
left a comment
tommymcm
left a comment
There was a problem hiding this comment.
Pretty close, I think there might be a bug in the tests and 1 formatting nit
xlauko
reviewed
Aug 31, 2025
xlauko
reviewed
Sep 2, 2025
bcardosolopes
approved these changes
Sep 3, 2025
Member
bcardosolopes
left a comment
bcardosolopes
left a comment
There was a problem hiding this comment.
LGTM after applying comments from @xlauko
tommymcm
pushed a commit
to tommymcm/clangir
that referenced
this pull request
Sep 5, 2025
bcardosolopes
added a commit
that referenced
this pull request
Sep 5, 2025
This reverts commit 4e092b2.
Member
|
Had to revert because it broke test on Linux: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1849