[a8 dos] Exit via DOSVEC #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwedgwood
force-pushed
the
atari8-dos-fix-exit
branch
3 times, most recently
from
0d8ca38
to
d9c1b2e
Compare
mysterymath
reviewed
May 29, 2024
There was a problem hiding this comment.
There's nothing unusual about JMP ($a) as an implementation of _Exit() (the C standard function that performs an immediate exit with no cleanup). Accordingly, we should merge the library exit-custom from common to provide the full exit() and after-main functionality in terms of _Exit() in atari-dos's crt0, and then the atari-dos target only needs to implement _Exit in its own _Exit.s
mysterymath
force-pushed
the
atari8-dos-fix-exit
branch
from
d9c1b2e
to
abc8a27
Compare
|
Went ahead and fixed this; landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.