Skip to content

fix: resolve JSON serialization error in active-request-scorer debug logs #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 3 commits into from
Feb 11, 2026
Merged

fix: resolve JSON serialization error in active-request-scorer debug logs #602

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
139bcce
fix: resolve JSON serialization error in active-request-scorer debug …
albertoperdomo2 Feb 8, 2026
f2d8342
feat: Add raw scores to debug
albertoperdomo2 Feb 8, 2026
9786729
Merge branch 'main' into fix/active-request-scorer-log-serialization
albertoperdomo2 Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion pkg/plugins/scorer/active_request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,18 @@ func (r requestEntry) String() string {
return fmt.Sprintf("%s:%s", r.RequestID, strings.Join(r.PodNames, "."))
}

// endpointScores implements logr.Marshaler to lazily convert endpoint keys
// to strings only when the log line is actually written.
type endpointScores map[scheduling.Endpoint]float64

func (s endpointScores) MarshalLog() interface{} {
result := make(map[string]float64, len(s))
for ep, score := range s {
result[ep.GetMetadata().NamespacedName.String()] = score
}
return result
}

// compile-time type assertion
var _ scheduling.Scorer = &ActiveRequest{}
var _ requestcontrol.PreRequest = &ActiveRequest{}
Expand Down Expand Up @@ -152,6 +164,8 @@ func (s *ActiveRequest) Score(ctx context.Context, _ *scheduling.CycleState, _ *
}
s.mutex.RUnlock()

log.FromContext(ctx).V(logutil.DEBUG).Info("Active request counts", "endpointCounts", scoredEndpoints, "maxCount", maxCount)

scoredEndpointsMap := make(map[scheduling.Endpoint]float64, len(endpoints))
for _, endpoint := range endpoints {
endpointName := endpoint.GetMetadata().NamespacedName.String()
Expand All @@ -166,7 +180,7 @@ func (s *ActiveRequest) Score(ctx context.Context, _ *scheduling.CycleState, _ *
}
}

log.FromContext(ctx).V(logutil.DEBUG).Info("Scored endpoints", "scores", scoredEndpointsMap)
log.FromContext(ctx).V(logutil.DEBUG).Info("Scored endpoints", "scores", endpointScores(scoredEndpointsMap))
return scoredEndpointsMap
}

Expand Down