-
Notifications
You must be signed in to change notification settings - Fork 265
refactor: kv cache manager repo #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
1c15fd2
refactor: kv cache manager repo name
sagearc 2683a46
Merge branch 'main' into rename-llmd-kv-cache
sagearc 2facce6
go mod tidy
sagearc 5755ebd
fetch kv cache upstream instead of my fork
sagearc 824c89b
revert dockerfile to fetch kv cache manager from upstream instead of …
sagearc 58f6a4b
update chat preprocessing structs
sagearc b89abce
update kv cache manager version
sagearc a26d4b1
refactor kvblock.Key to kvblock.BlockHash
sagearc 2e43da1
add context
sagearc 4e44531
add parent block key
sagearc 3a9a6d9
refactor encode
sagearc 9c820cf
validate model name
sagearc 4edcd32
run setup.sh
hyeongyun0916 2a5a77e
clone vllm into build
sagearc b63ef84
edit
hyeongyun0916 31eefb9
edit lint
hyeongyun0916 9c943e7
Merge commit 'f272b8549a9d870357aa9900ed972836136bc019' into rename-l…
hyeongyun0916 a50eb9d
delete fetch-python-wrapper.sh
hyeongyun0916 b9fd43d
edit git workflow
hyeongyun0916 d7653bf
edit
hyeongyun0916 05ba63c
Merge branch 'main' into rename-llmd-kv-cache
hyeongyun0916 2e59a41
refactor TokenProcessorConfig in config
sagearc cd74019
fix kv cache repo name in docker file
sagearc 7861c04
fix e2e tests
vMaroon c5f12b0
Merge commit '4884fc207f3bcafc8adb8fe705bbe114c6f9e9d4' into rename-l…
hyeongyun0916 886cb07
add ignore
hyeongyun0916 1848a6a
update architecture docs
sagearc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,32 +16,32 @@ set -euo pipefail | |
| VERSION="${1:-${KVCACHE_MANAGER_VERSION:-v0.3.2}}" | ||
| OUTPUT_DIR="${2:-llm-d-kv-cache-manager/pkg/preprocessing/chat_completions}" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like we should also remove |
||
|
|
||
| REPO_URL="https://github.com/llm-d/llm-d-kv-cache-manager.git" | ||
| REPO_URL="https://github.com/llm-d/llm-d-kv-cache.git" | ||
| WRAPPER_FILE="pkg/preprocessing/chat_completions/render_jinja_template_wrapper.py" | ||
|
|
||
| # Create temporary directory (equivalent to: mkdir -p /tmp/kv-cache-manager) | ||
| # TEMP_DIR will be an absolute path like /tmp/tmp.XXXXXX | ||
| TEMP_DIR=$(mktemp -d) | ||
| trap "rm -rf ${TEMP_DIR}" EXIT | ||
|
|
||
| echo "Fetching Python wrapper from llm-d-kv-cache-manager@${VERSION}..." | ||
| echo "Fetching Python wrapper from llm-d-kv-cache@${VERSION}..." | ||
|
|
||
| # Equivalent to: cd /tmp/kv-cache-manager && git clone ... . | ||
| # Equivalent to: cd /tmp/kv-cache && git clone ... . | ||
| # (clones repo contents directly into TEMP_DIR - using absolute path, no need to cd) | ||
| git clone --depth 1 --branch "${VERSION}" "${REPO_URL}" "${TEMP_DIR}" | ||
|
|
||
| # Create output directory if it doesn't exist | ||
| # (equivalent to: mkdir -p /workspace/llm-d-kv-cache-manager/pkg/preprocessing/chat_completions) | ||
| # (equivalent to: mkdir -p /workspace/llm-d-kv-cache/pkg/preprocessing/chat_completions) | ||
| # OUTPUT_DIR is relative to current working directory (relative path, same as original) | ||
| mkdir -p "${OUTPUT_DIR}" | ||
|
|
||
| # Copy wrapper file | ||
| # Source: absolute path ${TEMP_DIR}/${WRAPPER_FILE} (e.g., /tmp/tmp.XXXXXX/pkg/.../wrapper.py) | ||
| # Destination: relative path ${OUTPUT_DIR}/ (e.g., llm-d-kv-cache-manager/pkg/.../) | ||
| # Destination: relative path ${OUTPUT_DIR}/ (e.g., llm-d-kv-cache/pkg/.../) | ||
| # (equivalent to original: cp pkg/.../wrapper.py /workspace/... from within temp dir) | ||
| cp "${TEMP_DIR}/${WRAPPER_FILE}" "${OUTPUT_DIR}/" | ||
|
|
||
| # Cleanup happens automatically via trap (equivalent to: rm -rf /tmp/kv-cache-manager) | ||
| # Cleanup happens automatically via trap (equivalent to: rm -rf /tmp/kv-cache) | ||
|
|
||
| echo "Successfully fetched render_jinja_template_wrapper.py to ${OUTPUT_DIR}/" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.