Check the CONTAINER_TOOL value and use it in the e2e test script#364
Closed
hdefazio wants to merge 7 commits into
Closed
Check the CONTAINER_TOOL value and use it in the e2e test script#364hdefazio wants to merge 7 commits into
hdefazio wants to merge 7 commits into
Conversation
Signed-off-by: Hannah DeFazio <h2defazio@gmail.com>
Signed-off-by: Hannah DeFazio <h2defazio@gmail.com>
3 tasks
Collaborator
|
Please rebase this PR |
Member
Contributor
Author
|
@shmuelk @nirrozenbaum PTAL |
Collaborator
|
@hdefazio Please rebase your branch |
Contributor
Author
|
@shmuelk Done! |
elevran
approved these changes
Oct 20, 2025
| @if [ -z "$(CONTAINER_TOOL)" ]; then \ | ||
| echo "❌ Error: No container tool detected. Please install docker or podman."; \ | ||
| exit 1; \ | ||
| elif ! command -v $(CONTAINER_TOOL) >/dev/null 2>&1; then \ |
Collaborator
There was a problem hiding this comment.
Q: Since L40 sets CONTAINER_TOOL using command -v ..., can the check in L300 ever fail?
Contributor
Author
There was a problem hiding this comment.
yes that's fair - this was the original check for the make target so I didn't want to remove it. Without this, the check basically just becomes "Is CONTAINER_TOOL an empty string"?
Collaborator
There was a problem hiding this comment.
I think it is fine without the check on L300, since the value is set and confirmed using the same command.
Seems redundant to me but can keep or remove - both are fine.
@pierDipi - any thoughts?
Contributor
Author
|
closing in favor of #406 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
(this is correct for my system)
Other cases:
Manually set CONTAINER_TOOL := ""
Manually set CONTAINER_TOOL := "docker"
(this is correct for my system)
Merge criteria:
Summary by CodeRabbit
New Features
Improvements
Tests