Repository navigation
Send mm_payload with return_mm_kwargs on vLLM render copies - #3455
Merged
Merged
Conversation
vLLM replaced the return_mm_kwargs render option with mm_payload in vllm-project/vllm#61427 and kept return_mm_kwargs as an alias that is ignored when mm_payload is set, so a client-sent mm_payload overrides omitMMKwargs. Sending both keeps v0.32, which knows only return_mm_kwargs, and lets the router's values win on later versions. Signed-off-by: Maroon Ayoub <mayoub@redhat.com> Signed-off-by: Maroon Ayoub <Maroonay@gmail.com>
ahg-g
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
vllm.omitMMKwargsadds"mm_payload": "none"next to"return_mm_kwargs": falseon the render copy.vllm-project/vllm#61427 replaced the
return_mm_kwargsrender option withmm_payloadand keptreturn_mm_kwargsas a deprecated alias that vLLM ignores whenmm_payloadis set. With onlyreturn_mm_kwargson the render copy, a client that sends"mm_payload": "tensors"overrides the option on vLLMmain, so the render response carries the processed tensors again. Routing stays correct; render time goes back to the full-tensor cost.The vLLM v0.32 release branch has
return_mm_kwargsonly, so the render copy carries both fields: v0.32 readsreturn_mm_kwargs, and versions with vllm-project/vllm#61427 readmm_payload. Both are spliced after the client's fields, and the later duplicate key wins in vLLM's parser, so client values for either field are overridden. v0.32 logs the unknownmm_payloadat debug level only.omitMMKwargs: falsesends the render copy without either field, as before.Which issue(s) this PR fixes:
Part of #1552
Test plan
prefillOnly, the render copy keeps the output-budget rewrite and carries both fieldsomitMMKwargsfor chat, completions, Responses and Messages, validated with vLLM's request models fromreleases/v0.32.0(7960eeb9de) andmain(a97d19d792): v0.32 resolvesreturn_mm_kwargs=falseandmainresolvesmm_payload="none", including when the client sent"return_mm_kwargs": true, "mm_payload": "tensors"; no warnings loggedmake presubmitandmake test-unitRelease note (write
NONEif no user-facing change):