Skip to content

chore: drop plugin type from types and file#308

Merged
github-actions[bot] merged 1 commit into
llm-d:mainfrom
yyzxw:chore/update-filename
Aug 27, 2025
Merged

chore: drop plugin type from types and file#308
github-actions[bot] merged 1 commit into
llm-d:mainfrom
yyzxw:chore/update-filename

Conversation

@yyzxw
Copy link
Copy Markdown
Contributor

@yyzxw yyzxw commented Aug 21, 2025

close: #19

@yyzxw yyzxw force-pushed the chore/update-filename branch from c0da950 to fb7ea9c Compare August 21, 2025 03:51
Copy link
Copy Markdown
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments might still need the use of filter/scorer in them.

Comment thread .gitignore Outdated
Comment thread pkg/plugins/filter/by_label_selector.go Outdated
Comment thread pkg/plugins/filter/pd_role.go Outdated
Comment thread pkg/plugins/scorer/load_aware.go Outdated
Comment thread pkg/plugins/filter/pd_role.go Outdated
Comment thread pkg/plugins/filter/by_label.go Outdated
Comment thread pkg/plugins/filter/pd_role.go Outdated
Comment thread pkg/plugins/filter/pd_role.go Outdated
Comment thread pkg/plugins/scorer/session_affinity.go Outdated
Comment thread pkg/plugins/scorer/session_affinity.go Outdated
@elevran
Copy link
Copy Markdown
Collaborator

elevran commented Aug 25, 2025

@yyzxw thanks for the contribution!
I've left some minor comments (mostly relating to use of the filter/scorer in comments).
Please resolve conflicts/rebase and be sure to sign the commits

@yyzxw yyzxw force-pushed the chore/update-filename branch from fb7ea9c to 6827d97 Compare August 26, 2025 09:42
Copy link
Copy Markdown
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@elevran
Copy link
Copy Markdown
Collaborator

elevran commented Aug 26, 2025

thank you for following up on the review comments.
The code is still missing a verified signature.
See #311 (comment) for example and instructions.

@yyzxw yyzxw force-pushed the chore/update-filename branch from 6827d97 to b937ab2 Compare August 27, 2025 06:32
Signed-off-by: zxw <1020938856@qq.com>
@yyzxw yyzxw force-pushed the chore/update-filename branch from b937ab2 to d4b8c91 Compare August 27, 2025 06:34
@yyzxw
Copy link
Copy Markdown
Contributor Author

yyzxw commented Aug 27, 2025

all commits are signed now.

@elevran
Copy link
Copy Markdown
Collaborator

elevran commented Aug 27, 2025

/lgtm
/approve

@github-actions github-actions Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2025
@github-actions github-actions Bot merged commit 65ea8e0 into llm-d:main Aug 27, 2025
5 checks passed
zdtsw added a commit to zdtsw-forking/llm-d-inference-scheduler that referenced this pull request Apr 17, 2026
[cherrypick] code from ODH main to 3.4 EA2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider dropping plugin type qualifier from types and files

2 participants