cleanup: remove deprecated daulet tokenizer#274
Merged
Conversation
Signed-off-by: HyunKyun Moon <mhg5303@gmail.com>
hyeongyun0916
requested review from
dannyharnik and
kfirtoledo
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated daulet/tokenizers library from the build system. The daulet tokenizer was a C library binding that has been replaced by alternative tokenization implementations in previous commits. This PR completes the cleanup by removing build system references and configuration.
Changes:
- Removed tokenizer download and linking logic from the Makefile
- Updated CGO compiler and linker flags to remove tokenizer library references
- Removed tokenizer version configuration from Dockerfile
- Cleaned up .gitignore to remove /lib directory entry
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Removed tokenizer download section, updated CGO flags to remove -Ilib and -ltokenizers, removed download-tokenizer dependency from build targets |
| Dockerfile | Removed RELEASE_VERSION ARG and simplified build command |
| .gitignore | Removed /lib directory entry that was used for tokenizer binaries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Awesome. /lgtm |
github-actions
Bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary This PR removes the deprecated daulet/tokenizers from the Makefile and other configuration files. The core logic has been updated in previous commits, and this task completes the removal of the dependency from our build system.