Align the interface of the uds tokenizer service with Tokenizer#257
Merged
github-actions[bot] merged 1 commit intoJan 20, 2026
Merged
Conversation
Signed-off-by: 露营 <luying.yh@alibaba-inc.com>
delavet
requested review from
dannyharnik,
elevran,
kfirtoledo and
vMaroon
as code owners
vMaroon
reviewed
Jan 19, 2026
| """Initialize service with configuration""" | ||
| self.tokenizer = self._create_tokenizer(config.model) | ||
| self.config = config | ||
| def __init__(self, config: TokenizerConfig = None): |
Member
There was a problem hiding this comment.
Do you think this module can directly reuse the vLLM wrapping defined in the preprocessing package?
Collaborator
Author
There was a problem hiding this comment.
It is possible. I am actually preparing another PR to make the uds tokenizer use the vLLM wrapper. If you think it's OK, I can also add this directly to this PR.
Collaborator
Author
There was a problem hiding this comment.
Actually, I suggest preparing another PR to replace uds_tokenizer with the vLLM wrapper after the merge of #221. This is because, in the current main branch code, the vLLM wrapper only provides the apply_chat_template method so far. What do you think?
Member
|
/lgtm |
github-actions
Bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
guygir
pushed a commit
to guygir/llm-d-kv-cache-manager
that referenced
this pull request
Apr 20, 2026
Bumps the go-dependencies group with 3 updates: [github.com/alicebob/miniredis/v2](https://github.com/alicebob/miniredis), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) and [k8s.io/client-go](https://github.com/kubernetes/client-go). Updates `github.com/alicebob/miniredis/v2` from 2.34.0 to 2.35.0 - [Release notes](https://github.com/alicebob/miniredis/releases) - [Changelog](https://github.com/alicebob/miniredis/blob/master/CHANGELOG.md) - [Commits](alicebob/miniredis@v2.34.0...v2.35.0) Updates `k8s.io/apimachinery` from 0.33.2 to 0.33.3 - [Commits](kubernetes/apimachinery@v0.33.2...v0.33.3) Updates `k8s.io/client-go` from 0.33.2 to 0.33.3 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.33.2...v0.33.3) --- updated-dependencies: - dependency-name: github.com/alicebob/miniredis/v2 dependency-version: 2.35.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-dependencies - dependency-name: k8s.io/apimachinery dependency-version: 0.33.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-dependencies - dependency-name: k8s.io/client-go dependency-version: 0.33.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #207
This PR introduces two behavioral changes:
InitializeTokenizermethod, which allows the service to dynamically load the tokenizer for a model based on the model name passed in. This also enables us to configure the model loaded by the tokenizer through a unified configuration.addSpecialTokensparameter passed into theEncodemethod, rather than using a fixed value from the environment variables. This implementation aligns more closely with the definition of theTokenizerinterface.