fix(cgo): resolve CStrings memory leaks#249
Merged
Merged
Conversation
Signed-off-by: Sage Ahrac <sagiahrak@gmail.com>
sagearc
requested review from
dannyharnik,
elevran,
kfirtoledo and
vMaroon
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes memory leaks in CGO code by properly freeing CStrings allocated with C.CString(). The issue was that two functions were creating CStrings to pass JSON data to Python functions but never releasing the allocated memory.
- Added proper memory management for CString allocations in two functions
- Both functions now store the CString in a variable and use
defer C.free()to ensure cleanup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
This looks great. I think we should apply the same logic to this as well. |
hyeongyun0916
approved these changes
Jan 6, 2026
Member
|
/lgtm |
github-actions
Bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
guygir
pushed a commit
to guygir/llm-d-kv-cache-manager
that referenced
this pull request
Apr 20, 2026
* build: change epp-config default yaml * build: change imagePullPolicy to IfNotPresent for simulation Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com> --------- Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #248