Skip to content

feat: salt KV block hashes with LoRA adapter name #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Jan 5, 2026
Merged

feat: salt KV block hashes with LoRA adapter name #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions pkg/kvcache/kvevents/pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,12 @@ func (p *Pool) digestEvents(ctx context.Context, podIdentifier, modelName string
deviceTier = strings.ToLower(*ev.Medium)
}

// Use LoRA name for hashing if available, otherwise fall back to base model name.
Comment thread
sagearc marked this conversation as resolved.
effectiveModelName := modelName
if ev.LoraName != nil && *ev.LoraName != "" {
effectiveModelName = *ev.LoraName
}

// Create PodEntry for this specific event's device tier
podEntries := []kvblock.PodEntry{{PodIdentifier: podIdentifier, DeviceTier: deviceTier}}

Expand All @@ -231,7 +237,7 @@ func (p *Pool) digestEvents(ctx context.Context, podIdentifier, modelName string
debugLogger.Error(err, "Failed to convert block hash for BlockStored event", "rawHash", rawHash)
continue
}
engineKeys = append(engineKeys, kvblock.Key{ModelName: modelName, ChunkHash: hash})
engineKeys = append(engineKeys, kvblock.Key{ModelName: effectiveModelName, ChunkHash: hash})
}

var parentRequestKey *kvblock.Key
Expand All @@ -243,15 +249,18 @@ func (p *Pool) digestEvents(ctx context.Context, podIdentifier, modelName string
continue
}

parentEngineKey := kvblock.Key{ModelName: modelName, ChunkHash: hash}
parentEngineKey := kvblock.Key{ModelName: effectiveModelName, ChunkHash: hash}

key, err := p.index.GetRequestKey(ctx, parentEngineKey)
if err == nil {
parentRequestKey = &key
if err != nil {
debugLogger.Error(err, "Failed to get request key for parent block",
"parentEngineKey", parentEngineKey)
continue
}
parentRequestKey = &key
}

requestKeys := p.tokenProcessor.TokensToKVBlockKeys(parentRequestKey, ev.TokenIds, modelName)
requestKeys := p.tokenProcessor.TokensToKVBlockKeys(parentRequestKey, ev.TokenIds, effectiveModelName)

// Only proceed if we have valid keys to add.
if len(engineKeys) > 0 {
Expand Down
Loading