docs: update examples configuration#231
Merged
Merged
Conversation
sagearc
requested review from
dannyharnik,
elevran,
kfirtoledo and
vMaroon
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates example configurations to set the ModelName field in TokenizersPoolConfig, aligning with the changes introduced in PR #192 which refactored tokenizer initialization to load tokenizers once at pool initialization based on the base model name.
Key Changes:
- Added
ModelNameconfiguration to tokenizer pool setup across all examples - Ensures tokenizer initialization has the required model name parameter
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| examples/valkey_example/main.go | Sets ModelName to testdata.ModelName constant in Valkey configuration |
| examples/kv_events/offline/main.go | Sets ModelName to testdata.ModelName constant for offline events example |
| examples/kv_cache_index/main.go | Sets ModelName using getModelName() function which provides env var override with fallback |
| examples/kv_cache_aware_scorer/kvcache_aware_scorer.go | Sets ModelName from MODEL_NAME environment variable with validation |
| examples/helper/indexer.go | Sets ModelName to testdata.ModelName constant in helper configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
/lgtm |
github-actions
Bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update examples to configure the model name in the tokenization pool configuration.
ref: #192