feat(demo): add llm-d-async dispatcher support to deploy-k8s.sh - #607
Merged
Conversation
j-mok-dev
reviewed
Jul 20, 2026
Comment on lines
+1366
to
+1368
| kubectl delete deployment,svc,configmap,sa prometheus -n "${LLM_NAMESPACE}" 2>/dev/null || true | ||
| kubectl delete clusterrole,clusterrolebinding prometheus 2>/dev/null || true | ||
|
|
Collaborator
There was a problem hiding this comment.
nit: The ConfigMap created by install_prometheus is named prometheus-config, but the uninstall line targets configmap prometheus:
kubectl delete deployment,svc,configmap,sa prometheus -n "${LLM_NAMESPACE}" 2>/dev/null || true
this leaves prometheus-config behind after uninstall
Collaborator
Author
There was a problem hiding this comment.
good catch, fixed.
j-mok-dev
reviewed
Jul 20, 2026
| errors=$((errors + 1)) | ||
| fi | ||
|
|
||
| # 5. Prometheus has the metrics that prometheus-budget gate needs |
Collaborator
There was a problem hiding this comment.
broken numbering. should be 4
j-mok-dev
reviewed
Jul 20, 2026
| imagePullPolicy: IfNotPresent | ||
| messageQueueImpl: "redis-sortedset" | ||
| concurrency: 1 | ||
| prometheusURL: "${PROMETHEUS_URL}" |
Collaborator
There was a problem hiding this comment.
The script sets prometheusCacheTTL: "0s" in deploy_dispatcher, but this snippet doesn't include it. Without it, the default cache TTL applies and dispatch budget can be stale during short demo runs.
Collaborator
Author
There was a problem hiding this comment.
good catch! thanks
Signed-off-by: Raymond Zhao <zhaoeryi@gmail.com>
j-mok-dev
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR needed?
The
deploy-k8s.shdemo script only supports sync dispatch. Users cannot demo or test the async dispatch integration with llm-d-async.#458
What does this PR do?
Adds
ENABLE_DISPATCHER=truesupport to the deploy-k8s.sh demo script:dispatchMode: asyncwithinferencePoolNameprometheus-budgetgate)verify_dispatcher_config(install) checks processor config + Prometheus metrics;verify_dispatcher_runtime(test) checkssuccessful_requests_total+dispatch_budget+pool_worker_limitdeploy-k8s.mdanddocs/guides/deploy-k8s.mdwith async dispatch optionHow was this tested?
ENABLE_DISPATCHER=true ./deploy-k8s.sh install && ./deploy-k8s.sh test— 13/13 tests passed + dispatcher config/runtime verification passedChecklist
git commit -s) per DCOmake pre-commit)