Skip to content

fix(release-notes): trim trailing blank line from assembled RELEASE-NOTES.md #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shimib merged 1 commit into from
Jul 27, 2026
Merged

fix(release-notes): trim trailing blank line from assembled RELEASE-NOTES.md #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions hack/assemble-release-notes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ if [[ ! -f "$NOTES" ]] || ! grep -qF "$MARKER" "$NOTES"; then
fi

# Collect "<date>\t<pr>\t<url>\t<note>" rows, sorted by date then PR number.
rows=""; section=""; new=""
trap 'rm -f "$rows" "$section" "$new"' EXIT
rows=""; section=""; new=""; trimmed=""
trap 'rm -f "$rows" "$section" "$new" "$trimmed"' EXIT
rows="$(mktemp)"
for f in "${fragments[@]}"; do
pr="$(sed -n 's/^pr: *//p' "$f" | head -1)"
Expand Down Expand Up @@ -72,6 +72,13 @@ awk -v marker="$MARKER" -v sectionfile="$section" '
' "$NOTES" > "$new"
mv "$new" "$NOTES"

# Trim trailing blank lines so the file ends with exactly one newline. Each
# assembled section ends with a blank separator; on the first release that blank
# lands at EOF, which the end-of-file-fixer pre-commit hook rejects.
trimmed="$(mktemp)"
awk 'NF { last = NR } { line[NR] = $0 } END { for (i = 1; i <= last; i++) print line[i] }' "$NOTES" > "$trimmed"
mv "$trimmed" "$NOTES"

git rm --quiet -- "${fragments[@]}" 2>/dev/null || rm -f "${fragments[@]}"

echo "Assembled ${#fragments[@]} fragment(s) into $NOTES under 'RELEASE $VERSION $RELEASE_DATE'."
Expand Down
Loading