Repository navigation
[vLLM] [BugFix] Drop unused kv_transfer fields and rename group_id to group_idx - #4
Merged
Merged
Conversation
Remove kv_buffer_size, kv_ip, kv_parallel_size and kv_rank from the kv_transfer output. Rename group_id to group_idx in the kv-cache groups so it matches what vLLM now sends. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
hickeyma
changed the title
elevran
approved these changes
Oct 12, 2026
elevran
left a comment
elevran
left a comment
Collaborator
There was a problem hiding this comment.
straightforward bugfix matching upstream vLLM field removal/rename; README, schema, plugin, and test fixtures are all updated together.
8 tasks done
elevran
pushed a commit
that referenced
this pull request
Oct 15, 2026
A config field removed upstream used to raise in init_state and take down server startup which is what PR #4 had to patch around. Now a missing or retyped vLLM field comes back as null and logs a warning once. If a plugin still fails to initialize, its endpoint returns 503 and the server starts anyway. KV cache groups of a kind we don't know are reported as "unknown" with the original value in vllm_kind. Schema fields sourced from vLLM are nullable as a result. Adds a contract test that runs the plugins against vLLM's real config classes and fails when something we read is gone. CI also runs it against vLLM nightly and daily. Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
kv_buffer_size,kv_ip,kv_parallel_sizeandkv_rankfrom thekv_transfersection of the config endpoint. Also renamesgroup_idtogroup_idxin thekv-cachegroups. This matches what vLLM now sends.README and tests are updated to match.
Updates following changes in vLLM:
@elevran