Skip to content

Conversation

@AvinashAgarwal14
Copy link

No description provided.

@llaske
Copy link
Owner

llaske commented Aug 3, 2019

Could you resolve conflict, it will be easier for me to test it.

@llaske
Copy link
Owner

llaske commented Aug 4, 2019

It's a good start.
My remarks:

  • Look like Undo button has no effect
  • Flip and Rotate buttons effect can't be saved
  • What the difference between OK button and Saved button?
  • Is it possible to change button icons. I would like to have more Sugar compatible button for OK/Cancel button

@AvinashAgarwal14
Copy link
Author

  • Changes made to an image are saved only when a new image URL is created and it happens only when crop feature is used. So the user can flip the image but they will have to crop the flipped image to see the changes.
    Similarly, undo is used also when the image is cropped.
  • The ok button is used to confirm cropped image and save button is used to change the image source( when the editor is closed the changes are reflected in the calling screen only when save button is pressed) as well.
  • Sure, the button's image can be changed let me know which images are to be used.

@llaske
Copy link
Owner

llaske commented Aug 4, 2019

Hmmm. It's not possible to force user to crop if he want only flip/rotate.
The undo should work also for all features not only crop.
It's not intuitive at all. Could you see what could be done to change this standard features?
Regarding saving file and icons, it should match the standard popup dialog feature (for example in Sugarizer settings). So I guess we should only have two buttons on the top right of the screen: one for close/save, one for close/cancel.

@llaske
Copy link
Owner

llaske commented Aug 10, 2019

Good job.
Few remarks:

  • The cancel button on the first popup (the one with the edit button) should be replace by a ok button (because it's validate the user choice)
  • When the cancel button and the ok button appears the ok button should be always on the right
  • The cancel button and the ok button on the toolbar should be removed because there are useless: the user should use ok/cancel button on the top right of the window
  • Image cropped are no longer saved except if the ok button on the toolbar is clicked first
  • Zoom actions are no saved

@llaske llaske merged commit 252c723 into llaske:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants