Conversation
meta-cla
bot
added
the
CLA Signed
ehhuang
force-pushed
the
pr3761
branch
10 times, most recently
from
af63e22 to
68b645c
Compare
ehhuang
changed the title
ehhuang
requested review from
ashwinb,
bbrowning,
franciscojavierarceo,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
ehhuang
changed the title
ehhuang
changed the title
ehhuang
force-pushed
the
pr3761
branch
3 times, most recently
from
f5b5a2d to
16adbdc
Compare
ehhuang
changed the title
ashwinb
reviewed
Oct 10, 2025
ashwinb
reviewed
Oct 10, 2025
ashwinb
reviewed
Oct 10, 2025
ehhuang
force-pushed
the
pr3761
branch
2 times, most recently
from
b22d531 to
361fcaf
Compare
# What does this PR do? ## Test Plan # What does this PR do? ## Test Plan
franciscojavierarceo
pushed a commit
to franciscojavierarceo/llama-stack
that referenced
this pull request
Oct 11, 2025
…ct (llamastack#3761) # What does this PR do? Converts openai(_chat)_completions params to pydantic BaseModel to reduce code duplication across all providers. ## Test Plan CI --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/llamastack/llama-stack/pull/3761). * llamastack#3777 * __->__ llamastack#3761
jwm4
pushed a commit
to jwm4/llama-stack
that referenced
this pull request
Oct 13, 2025
…ct (llamastack#3761) # What does this PR do? Converts openai(_chat)_completions params to pydantic BaseModel to reduce code duplication across all providers. ## Test Plan CI --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/llamastack/llama-stack/pull/3761). * llamastack#3777 * __->__ llamastack#3761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Converts openai(_chat)_completions params to pydantic BaseModel to reduce code duplication across all providers.
Test Plan
CI
Stack created with Sapling. Best reviewed with ReviewStack.
extra_bodythrough to providers #3777