chore: replace use llama_stack logger#3060
Closed
Elbehery wants to merge 1 commit intollamastack:mainfrom
Closed
Conversation
Elbehery
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
cdoern
reviewed
Aug 7, 2025
Collaborator
cdoern
left a comment
cdoern
left a comment
There was a problem hiding this comment.
some comments on the category names here and a few other things
Elbehery
force-pushed
the
20250807_use_llama-stack_logger
branch
2 times, most recently
from
98db31f to
d447738
Compare
rhuss
reviewed
Aug 7, 2025
| from .persistence import AgentInfo | ||
|
|
||
| logger = logging.getLogger() | ||
| logger = get_logger(name=__name__, category="llama") |
Contributor
There was a problem hiding this comment.
Why is this not agents category (like in the diff below) ? Where is this llama coming from ?
Contributor
Author
There was a problem hiding this comment.
+1, should be agents 👍🏽
fixing all this in a separate PR now :)
Contributor
Author
There was a problem hiding this comment.
I have removed the changes which only renames the categories to #3065
the changes which replaces
logger = logging.getLogger(__name__)
with
logger = get_logger(name=__name__, category="")
Still in this PR
ptal 👍🏽
Elbehery
force-pushed
the
20250807_use_llama-stack_logger
branch
from
d447738 to
c5793f6
Compare
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
20250807_use_llama-stack_logger
branch
from
c5793f6 to
b5f98c0
Compare
Contributor
Author
|
This change has been added in 348cf69 Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces default logger usage with custom
llama_stacklogger.This PR aligns logging categories as per the
packagename, as well as reviews from initial PRReplaces #2868
Part of #2865
cc @leseb @ashwinb @rhuss