feat(registry): make the Stack query providers for model listing#2862
Merged
ashwinb merged 7 commits intollamastack:mainfrom Jul 24, 2025
Merged
feat(registry): make the Stack query providers for model listing#2862ashwinb merged 7 commits intollamastack:mainfrom
ashwinb merged 7 commits intollamastack:mainfrom
Conversation
ashwinb
requested review from
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
terrytangyuan and
yanxi0830
as code owners
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
cc @mattf particularly, since you may have thoughts given your recent changes -- the addition of |
Contributor
Author
|
cc @cdoern the post-training tests are failing, what might I be doing wrong? |
Contributor
Author
|
I will make a PR after this which removes explicit model registration from templates like |
mattf
reviewed
Jul 23, 2025
This was referenced Jul 23, 2025
…ch can create forever running background threads
ChristianZaccaria
pushed a commit
to ChristianZaccaria/llama-stack
that referenced
this pull request
Jul 28, 2025
…mastack#2862) This flips llamastack#2823 and llamastack#2805 by making the Stack periodically query the providers for models rather than the providers going behind the back and calling "register" on to the registry themselves. This also adds support for model listing for all other providers via `ModelRegistryHelper`. Once this is done, we do not need to manually list or register models via `run.yaml` and it will remove both noise and annoyance (setting `INFERENCE_MODEL` environment variables, for example) from the new user experience. In addition, it adds a configuration variable `allowed_models` which can be used to optionally restrict the set of models exposed from a provider.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flips #2823 and #2805 by making the Stack periodically query the providers for models rather than the providers going behind the back and calling "register" on to the registry themselves. This also adds support for model listing for all other providers via
ModelRegistryHelper. Once this is done, we do not need to manually list or register models viarun.yamland it will remove both noise and annoyance (settingINFERENCE_MODELenvironment variables, for example) from the new user experience.In addition, it adds a configuration variable
allowed_modelswhich can be used to optionally restrict the set of models exposed from a provider.