fix: remove @pytest.mark.asyncio from test_get_raw_document_text.py#2840
Merged
ashwinb merged 1 commit intollamastack:mainfrom Jul 21, 2025
Merged
fix: remove @pytest.mark.asyncio from test_get_raw_document_text.py#2840ashwinb merged 1 commit intollamastack:mainfrom
ashwinb merged 1 commit intollamastack:mainfrom
Conversation
r3v5
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
ChristianZaccaria
approved these changes
Jul 21, 2025
Contributor
ChristianZaccaria
left a comment
ChristianZaccaria
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thanks!
Contributor
|
the fix the CI failure is in #2815 |
ashwinb
approved these changes
Jul 21, 2025
Contributor
|
how did the breakage land? |
Contributor
Author
|
I think the problem occurred after this PR was merged. The new test file was introduced there. |
Collaborator
|
@ashwinb @r3v5 looks like #2575 was using an old pre-commit config and thus missed the new config that's on main, note the async check isn't present in https://github.com/meta-llama/llama-stack/actions/runs/16318322210/job/46091440015 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The pre-commit workflow was failing in the main branch and removing
@pytest.mark.asynciofromtest_get_raw_document_text.pyfixed that.Test Plan