fix: graceful SIGINT on server#2831
Merged
ashwinb merged 1 commit intollamastack:mainfrom Jul 21, 2025
Merged
Conversation
After llamastack#2818, SIGINT will print a stack trace. This is because uvicorn re-raises SIGINT and it gets converted by Python internal signal handler (default handles SIGINT) to KeyboardInterrupt exception. We know simply catch the exception to get a clean exit, this is not changing the behavior on SIGINT. Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
mattf,
raghotham,
reluctantfuturist,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
Collaborator
Contributor
I think those could be complementary. In general, we should keep the lifetimes of the provider and the server synchronized. What you propose (re: other lifecycle methods) is certainly a good idea but that could be done in addition to this. |
ashwinb
approved these changes
Jul 21, 2025
Contributor
ashwinb
left a comment
ashwinb
left a comment
There was a problem hiding this comment.
ah thank you. I got confused too seeing the new stacktraces but didn't pay close attention :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After #2818, SIGINT will print a stack trace. This is because uvicorn re-raises SIGINT and it gets converted by Python internal signal handler (default handles SIGINT) to KeyboardInterrupt exception. We know simply catch the exception to get a clean exit, this is not changing the behavior on SIGINT.
Test Plan
Run the server, hit Ctrl+C or
kill -2 <server pid>and expect a clean exit with no stack trace.