fix(vectordb): VectorDBInput has no provider_id#2830
Merged
leseb merged 1 commit intollamastack:mainfrom Jul 21, 2025
Merged
Conversation
Elbehery
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
Contributor
Author
leseb
requested changes
Jul 21, 2025
Collaborator
leseb
left a comment
leseb
left a comment
There was a problem hiding this comment.
Tested the change locally and confirmed it works, however I have a small concern provider_id being optional here.
| vector_db_id: str | ||
| embedding_model: str | ||
| embedding_dimension: int | ||
| provider_id: str | None = None |
Collaborator
There was a problem hiding this comment.
Shouldn't provider_id be mandatory? Otherwise, how do we determine to which provider we should be routing to?
Collaborator
There was a problem hiding this comment.
Oh I see, we have:
if provider_id is None:
if len(self.impls_by_provider_id) > 0:
provider_id = list(self.impls_by_provider_id.keys())[0]
if len(self.impls_by_provider_id) > 1:
logger.warning(
f"No provider specified and multiple providers available. Arbitrarily selected the first provider {provider_id}."
)
Which seems really arbitrary, but anyways this is a discussion for another time I guess.
Contributor
Author
There was a problem hiding this comment.
Would you kindly raise an issue with the future work ?
Contributor
Author
There was a problem hiding this comment.
i see u raised #2834
i have signed up for it 👍🏽
leseb
approved these changes
Jul 21, 2025
Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
20250721_fix_vectordb_provider_id
branch
from
a9c799f to
1c9b744
Compare
Contributor
Author
|
failure is fixed in #2815 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add
provider_idfield toVectorDBInputclass.fixes #2819