explicitly empty test command args

See spf13/cobra#155

Errors can still be encountered when, for example, using precomiled
tests.  Explicitly setting constructed command args to the empty slice
ensures we avoid hitting any futher edge cases.

cmd/config_labels_test.go

@@ -106,6 +106,7 @@ func TestNewConfigLabelsCmd(t *testing.T) {
 	labels := &loaderSaver.f.Labels
 
 	cmd := NewConfigLabelsCmd(&loaderSaver)
+	cmd.SetArgs([]string{}) // Do not use test command args
 
 	run := createRunFunc(cmd, t)
 
@@ -143,6 +144,7 @@ func TestListLabels(t *testing.T) {
 	*labels = append(*labels, p("a", "b"), p("c", "d"))
 
 	cmd := NewConfigLabelsCmd(&loaderSaver)
+	cmd.SetArgs([]string{}) // Do not use test command args
 
 	ctx := context.Background()
 	c, _, err := vt10x.NewVT10XConsole()
@@ -151,8 +153,6 @@ func TestListLabels(t *testing.T) {
 	}
 	defer c.Close()
 
-	cmd.SetArgs(make([]string, 0))
-
 	errChan := make(chan error, 1)
 	func() {
 		var err error

cmd/create_test.go

@@ -28,6 +28,7 @@ func TestCreate_NoRuntime(t *testing.T) {
 	defer Fromtemp(t)()
 
 	cmd := NewCreateCmd(NewClient)
+	cmd.SetArgs([]string{}) // Do not use test command args
 
 	err := cmd.Execute()
 	var e ErrNoRuntime
@@ -96,6 +97,7 @@ func TestCreateConfig_RepositoriesPath(t *testing.T) {
 	expected := filepath.Join(xdgConfigHome, "func", "repositories")
 
 	cmd := NewCreateCmd(NewClient)
+	cmd.SetArgs([]string{}) // Do not use test command args
 	cfg, err := newCreateConfig(cmd, []string{}, NewClient)
 	if err != nil {
 		t.Fatal(err)

cmd/delete_test.go

@@ -81,9 +81,9 @@ created: 2021-01-01T00:00:00+00:00
 	cmd := NewDeleteCmd(NewClientFactory(func() *fn.Client {
 		return fn.New(fn.WithRemover(remover))
 	}))
+	cmd.SetArgs([]string{}) // Do not use test command args
 
 	// Execute the command simulating no arguments.
-	cmd.SetArgs([]string{})
 	err := cmd.Execute()
 	if err != nil {
 		t.Fatal(err)

cmd/deploy_test.go

@@ -116,6 +116,7 @@ created: 2009-11-10 23:00:00`,
 					fn.WithPipelinesProvider(pipeline),
 					fn.WithDeployer(deployer))
 			}))
+			cmd.SetArgs([]string{}) // Do not use test command args
 
 			// TODO: the below viper.SetDefault calls appear to be altering
 			// the default values of flags as a way set various values of flags.

cmd/repository_test.go

@@ -15,6 +15,7 @@ import (
 func TestRepository_List(t *testing.T) {
 	defer WithEnvVar(t, "XDG_CONFIG_HOME", t.TempDir())()
 	cmd := NewRepositoryListCmd(NewClient)
+	cmd.SetArgs([]string{}) // Do not use test command args
 
 	// Execute the command, capturing the output sent to stdout
 	stdout := piped(t)
@@ -40,6 +41,9 @@ func TestRepository_Add(t *testing.T) {
 		list   = NewRepositoryListCmd(NewClient)
 		stdout = piped(t)
 	)
+	// Do not use test command args
+	add.SetArgs([]string{})
+	list.SetArgs([]string{})
 
 	// add [flags] <old> <new>
 	add.SetArgs([]string{
@@ -76,6 +80,10 @@ func TestRepository_Rename(t *testing.T) {
 		list   = NewRepositoryListCmd(NewClient)
 		stdout = piped(t)
 	)
+	// Do not use test command args
+	add.SetArgs([]string{})
+	rename.SetArgs([]string{})
+	list.SetArgs([]string{})
 
 	// add a repo which will be renamed
 	add.SetArgs([]string{"newrepo", TestRepoURI("repository", t)})
@@ -118,6 +126,10 @@ func TestRepository_Remove(t *testing.T) {
 		list   = NewRepositoryListCmd(NewClient)
 		stdout = piped(t)
 	)
+	// Do not use test command args
+	add.SetArgs([]string{})
+	remove.SetArgs([]string{})
+	list.SetArgs([]string{})
 
 	// add a repo which will be removed
 	add.SetArgs([]string{"newrepo", TestRepoURI("repository", t)})

cmd/root_test.go

@@ -38,7 +38,7 @@ func TestRoot_PersistentFlags(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			defer Fromtemp(t)()                       // from a temp dir, deferred cleanup
-			cmd := NewCreateCmd(NewClient)          // Create a new Function
+			cmd := NewCreateCmd(NewClient)            // Create a new Function
 			cmd.SetArgs([]string{"--language", "go"}) // providing language (the only required param)
 			if err := cmd.Execute(); err != nil {     // fail on any errors
 				t.Fatal(err)
@@ -188,6 +188,7 @@ func TestRoot_CommandNameParameterized(t *testing.T) {
 			cmd = NewRootCmd(RootCommandConfig{Name: testName})
 			out = strings.Builder{}
 		)
+		cmd.SetArgs([]string{}) // Do not use test command args
 		cmd.SetOut(&out)
 		if err := cmd.Help(); err != nil {
 			t.Fatal(err)

cmd/run_test.go

@@ -95,6 +95,7 @@ created: 2009-11-10 23:00:00`,
 					fn.WithRegistry("ghcr.com/reg"),
 				)
 			}))
+			cmd.SetArgs([]string{}) // Do not use test command args
 
 			// set test case's build
 			viper.SetDefault("build", tt.buildFlag)