Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verbose behavior #408

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Fix verbose behavior #408

merged 2 commits into from
Jun 15, 2020

Conversation

nishnash54
Copy link
Contributor

Fix verbose behavior.

Description

Toggled verbose options.

  • verbose=False silent mode
  • verbose=True display status bar.

Related Issue

#406

How Has This Been Tested?

Added new test for verbose behavior. Silent mode shows no output. verbose = True shows status bar.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nishnash54
verbose
2824dc3 
- fix bug (False -> silent)
- log_level
@nishnash54
verbosity test
1f55e3d 
- silent mode (no outputs)
- verbose (status bar)
@ljvmiranda921
Copy link
Owner

Thanks for this, @nishnash54 !

@ljvmiranda921 ljvmiranda921 merged commit 9fcfbc6 into ljvmiranda921:master Jun 15, 2020
@nishnash54 nishnash54 deleted the fix-verbose branch June 16, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljvmiranda921 ljvmiranda921 ljvmiranda921 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nishnash54 @ljvmiranda921